Unclear variable name and incompatible type when construct hash.

[chengjackjelly]

Hi, we are student from Linköping university. We are using the script you provide to generate DETs and use it in our transmitter as part of prototype implementation to DRIP. The DET generated so far has some problem when we try to verify the ORCHID hash it constructed. We look into the script and identify some issues.

For code below:

drip-scripts/csr-gen.py

Line 46 in 1fa1f88

h_orchid_left = unhexlify(b_prefix + b_hid + b_ogaid)

• It's unclear to use h_orchid_left to refer to a binary data.
• The unhexlify function is taking binary data as input here.

For code below:

drip-scripts/csr-gen.py

Line 52 in 1fa1f88

shake.update((h_orchid_left + hi))

• The hash should be constructed by binary data. Here is a mix of binary data(h_orchid_left) and a bytes object in hexadecimal representation.