fix(rush): treat non-terminal statuses as non-terminal (microsoft#5277)

* fix: do not try and sync on cobuild waiting

Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>

* add changeset

Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>

* only assign operations on complete

Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>

* update changeset

Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>

* fix snapshots

Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>

* Update libraries/rush-lib/src/logic/operations/OperationExecutionManager.ts

Co-authored-by: David Michon <dmichon@microsoft.com>

* fix test cases

Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>

* Update libraries/rush-lib/src/logic/operations/OperationExecutionManager.ts

---------

Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Co-authored-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Co-authored-by: David Michon <dmichon@microsoft.com>

Author: aramissennyeydd

common/changes/@microsoft/rush/sennyeya-fix-pnpm-sync_2025-07-18-17-47.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "Do not run afterExecuteOperation if the operation has not actually completed.",
+      "type": "none",
+      "packageName": "@microsoft/rush"
+    }
+  ],
+  "packageName": "@microsoft/rush",
+  "email": "aramissennyeydd@users.noreply.github.com"
+}

libraries/rush-lib/src/logic/operations/OperationExecutionManager.ts

@@ -263,14 +263,19 @@ export class OperationExecutionManager {
     const onOperationCompleteAsync: (record: OperationExecutionRecord) => Promise<void> = async (
       record: OperationExecutionRecord
     ) => {
-      try {
-        await this._afterExecuteOperation?.(record);
-      } catch (e) {
-        this._reportOperationErrorIfAny(record);
-        record.error = e;
-        record.status = OperationStatus.Failure;
+      // If the operation is not terminal, we should _only_ notify the queue to assign operations.
+      if (!record.isTerminal) {
+        this._executionQueue.assignOperations();
+      } else {
+        try {
+          await this._afterExecuteOperation?.(record);
+        } catch (e) {
+          this._reportOperationErrorIfAny(record);
+          record.error = e;
+          record.status = OperationStatus.Failure;
+        }
+        this._onOperationComplete(record);
       }
-      this._onOperationComplete(record);
     };
 
     const onOperationStartAsync: (
@@ -296,8 +301,8 @@ export class OperationExecutionManager {
     const status: OperationStatus = this._hasAnyFailures
       ? OperationStatus.Failure
       : this._hasAnyNonAllowedWarnings
-      ? OperationStatus.SuccessWithWarning
-      : OperationStatus.Success;
+        ? OperationStatus.SuccessWithWarning
+        : OperationStatus.Success;
 
     return {
       operationResults: this._executionRecords,
@@ -431,13 +436,12 @@ export class OperationExecutionManager {
         this._hasAnyNonAllowedWarnings = this._hasAnyNonAllowedWarnings || !runner.warningsAreAllowed;
         break;
       }
-    }
 
-    if (record.isTerminal) {
-      // If the operation was not remote, then we can notify queue that it is complete
-      this._executionQueue.complete(record);
-    } else {
-      this._executionQueue.assignOperations();
+      default: {
+        throw new InternalError(`Unexpected operation status: ${status}`);
+      }
     }
+
+    this._executionQueue.complete(record);
   }
 }