Free PID-Controller coeffcient change only active after reboot

[wimalopaan]

Actually I'm trying to explore the Programmig -> PID Controllers.

I have setup a simple PID Controller: enabled, setpoint=0, measurement=roll, P=1000 (=1.0), I=D=FF=0.

If I "save" these values, the PID-Controller looks inactive, it produces output constantly 0. Powercycling the FC seems to help. The same is true for changing the coefficients of the PID controller: "saving" the new values do not make them active, it is required to reboot the FC.

This looks like a bug, because the logs say that the values are saved. But the new values do not have any effect.

P.S. "Saving" new ranges of channel values in the "Modes" tab makes them used without a reboot. This seems to be the correct behaviour.

[Jetrell]

@wimalopaan I used that PID controller in this project last year. And from tuning tests over multiple flights. I did succeed in tightening the tune of the throttle/speed. And that using different tunes on a few airframes.
However I haven't flown with that function using 9.0.
Have you traced back to when this issue might have occurred ?

BTW I found 1000 was the limit.

[wimalopaan]

Have you traced back to when this issue might have occurred ?

No, didn't bisect that issue.

BTW I found 1000 was the limit.

Yes, the coefficients are scaled by 1/1000 and limited to [0:32767]. The output is limited to 1.0, scaled by 1000.

[wimalopaan]

@wimalopaan I used that PID controller in this project last year. And from tuning tests over multiple flights. I did succeed in tightening the tune of the throttle/speed. And that using different tunes on a few airframes. However I haven't flown with that function using 9.0. Have you traced back to when this issue might have occurred ?

BTW I found 1000 was the limit.

Actually I can't find a way to use the PID-controller output in a mixer line. Any hints?

[wimalopaan]

Solution: #11435