ci: run e2e on direct main pushes only (#195)

* ci: run e2e on direct main pushes only

Keep E2E as a PR check, but skip redundant runs on merge commits by running on main only when the pushed commit is not associated with any PR.

* ci: ensure e2e runs on PRs

Make the direct-push detection job always complete so PR-triggered E2E isn't skipped due to a missing/conditional dependency.

* ci: update e2e workflow to use Playwright container

Configure the e2e job to run in a Playwright container, improving consistency and reliability. Removed caching and installation steps for Playwright browsers as they are now handled within the container.

* ci: install unzip in e2e container

Ensure oven-sh/setup-bun works inside the Playwright container by installing unzip before setting up Bun.

* ci: set HOME for Firefox in playwright container

Playwright Firefox requires $HOME to be owned by the running user inside the container; set HOME=/root so Firefox can launch reliably in CI.

* ci: update e2e workflow to set HOME for Playwright user

Change the HOME environment variable to /home/pwuser and add user option to the Playwright container to ensure proper permissions for Firefox execution in CI.

* ci: use correct Playwright container user uid

Run the e2e container as uid 1000 so actions and Playwright Firefox share a writable, owned home directory and avoid checkout permission failures.

* ci: restore root runner context in e2e container

Remove the custom container user so GitHub action file commands can write to runner temp paths, while keeping HOME on /root for Firefox launch stability.

---------

Co-authored-by: Nico Prananta <311343+nicnocquee@users.noreply.github.com>

Author: nicnocquee

.github/workflows/e2e.yml

@@ -7,13 +7,55 @@ on:
       - main
   workflow_dispatch:
 
+permissions:
+  contents: read
+  pull-requests: read
+
 concurrency:
   group: e2e-${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
+  direct_push_check:
+    name: Detect direct push to main
+    runs-on: ubuntu-latest
+    outputs:
+      is_direct: ${{ steps.detect.outputs.is_direct }}
+    steps:
+      - name: Determine if commit belongs to a PR
+        id: detect
+        uses: actions/github-script@v8
+        with:
+          script: |
+            if (context.eventName !== 'push' || context.ref !== 'refs/heads/main') {
+              // Only `push` to `main` needs direct-vs-merge detection.
+              core.setOutput('is_direct', 'false')
+              return
+            }
+
+            const sha = context.sha
+            // If this commit is associated with any PR, it's almost certainly coming from a PR merge.
+            // Direct pushes to main won't have associated PRs.
+            const { data } = await github.rest.repos.listPullRequestsAssociatedWithCommit({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              commit_sha: sha,
+            })
+
+            core.setOutput('is_direct', String(data.length === 0))
+
   e2e:
     runs-on: ubuntu-latest
+    container:
+      image: mcr.microsoft.com/playwright:v1.57.0-jammy
+      options: --ipc=host
+    needs: [direct_push_check]
+    if: |
+      github.event_name == 'pull_request' ||
+      (github.event_name == 'push' && github.ref == 'refs/heads/main' && needs.direct_push_check.outputs.is_direct == 'true')
+    env:
+      # Playwright's Firefox won't launch in the container unless $HOME is owned by the current user.
+      HOME: /root
     timeout-minutes: 45
     strategy:
       fail-fast: false
@@ -46,6 +88,9 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
 
+      - name: Install unzip
+        run: apt-get update && apt-get install -y unzip
+
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with:
@@ -62,17 +107,6 @@ jobs:
       - name: Install dependencies
         run: bun install --frozen-lockfile
 
-      - name: Cache Playwright browsers
-        uses: actions/cache@v4
-        with:
-          path: ~/.cache/ms-playwright
-          # Cache per-browser to avoid cross-job races and partial caches
-          # when matrix runs in parallel.
-          key: ${{ runner.os }}-playwright-${{ matrix.browser }}-${{ hashFiles('bun.lock') }}
-
-      - name: Install Playwright browsers
-        run: bunx playwright install ${{ matrix.browser }} --with-deps
-
       - name: Build app
         run: bun run build
 
@@ -94,11 +128,14 @@ jobs:
     name: Merge Playwright report
     runs-on: ubuntu-latest
     if: always()
-    needs: [e2e]
+    needs: [direct_push_check, e2e]
     steps:
       - name: Checkout
         uses: actions/checkout@v6
 
+      - name: Install unzip
+        run: sudo apt-get update && sudo apt-get install -y unzip
+
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with: