-
Notifications
You must be signed in to change notification settings - Fork 177
Open
Description
It's a bit confusing when you write:
item.save()
item.full_clean()while the name of the tests is test_cannot_save_empty_list_item
Because in the end... the item is saved. It can be verified by putting the following right after the with block:
self.assertEqual(Item.objects.count(), 0)Two potential solutions
-
Maybe just swapping the order of the 2 lines might make things less confusing :)
item.full_clean() item.save()
-
Another solution would be to simply rename the tests from
test_cannot_save_empty_list_itemtotest_cannot_validate_empty_list_item
And removing the call tosave()alltogether.
Metadata
Metadata
Assignees
Labels
No labels