Skip to content

Commit aa64ac2

Browse files
committed
Stop marking abstract methods too long
Fixes #19
1 parent 9a6d063 commit aa64ac2

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

CleanCode/src/CleanCode.nuspec

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<package >
33
<metadata>
44
<id>CleanCode.CleanCode</id>
5-
<version>5.0.2</version>
5+
<version>5.0.3</version>
66
<title>Clean Code</title>
77
<authors>Hadi Hariri, Matt Ellis, SuperJMN</authors>
88
<owners>Hadi Hariri, Matt Ellis</owners>
@@ -12,6 +12,9 @@
1212
<requireLicenseAcceptance>false</requireLicenseAcceptance>
1313
<description>Automates some of the concepts in Uncle Bob's Clean Code book</description>
1414
<releaseNotes>
15+
&#8226; Stop marking abstract methods too long (#19)
16+
17+
From 5.0.2:
1518
&#8226; Method parameter and type parameter declarations mistakenly used for "method too long" check (#12)
1619

1720
From 5.0.1:

CleanCode/src/CleanCode/Features/MethodTooLong/MethodTooLongCheck.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ protected override void Run(IMethodDeclaration element, ElementProblemAnalyzerDa
2424
// Only look in the method body for declarations, otherwise we see
2525
// parameters + type parameters. We can ignore arrow expressions, as
2626
// they must be a single expression and won't have declarations
27-
var declarationCount = element.Body?.CountChildren<IDeclaration>();
27+
var declarationCount = element.Body?.CountChildren<IDeclaration>() ?? 0;
2828
if (declarationCount <= maxDeclarations)
2929
return;
3030
}

CleanCode/src/CleanCode/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@
1212
[assembly: ComVisible(false)]
1313
[assembly: Guid("97927FF9-8C9C-4DC5-A309-29C23F41DA47")]
1414

15-
[assembly: AssemblyVersion("5.0.2.0")]
16-
[assembly: AssemblyFileVersion("5.0.2.0")]
15+
[assembly: AssemblyVersion("5.0.3.0")]
16+
[assembly: AssemblyFileVersion("5.0.3.0")]

0 commit comments

Comments
 (0)