Skip to content

Commit 2ba7e62

Browse files
Minor: reposition suppresion lines
Move each comment directly above the `[=](...)`. Resolves: DATASDK-104 Signed-off-by: Iwo Sidorowicz <iwo.sidorowicz@here.com>
1 parent a4bfde6 commit 2ba7e62

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

olp-cpp-sdk-dataservice-write/src/IndexLayerClientImpl.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ client::CancellationToken IndexLayerClientImpl::UpdateIndex(
310310
client::ErrorCode::Cancelled, "Operation cancelled.", true)));
311311
};
312312

313+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
313314
auto updateIndex_callback = [=](UpdateIndexResponse update_index_response) {
314315
self->tokenList_.RemoveTask(op_id);
315316
if (!update_index_response.IsSuccessful()) {

olp-cpp-sdk-dataservice-write/src/VersionedLayerClientImpl.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,8 @@ olp::client::CancellationToken VersionedLayerClientImpl::GetBaseVersion(
231231
"Operation cancelled.", true));
232232
};
233233

234-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
235234
auto getBaseVersion_callback =
235+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
236236
[=](MetadataApi::CatalogVersionResponse response) {
237237
self->tokenList_.RemoveTask(id);
238238
if (!response.IsSuccessful()) {
@@ -309,8 +309,8 @@ olp::client::CancellationToken VersionedLayerClientImpl::GetBatch(
309309
"Operation cancelled.", true));
310310
};
311311

312-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
313312
auto getPublication_callback =
313+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
314314
[=](GetPublicationResponse getPublicationResponse) {
315315
self->tokenList_.RemoveTask(id);
316316
if (!getPublicationResponse.IsSuccessful()) {
@@ -574,8 +574,8 @@ client::CancellationToken VersionedLayerClientImpl::CheckDataExists(
574574
auto cancel_context = std::make_shared<client::CancellationContext>();
575575
auto id = tokenList_.GetNextId();
576576

577-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
578577
auto check_data_exists_callback =
578+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
579579
[=](CheckDataExistsResponse check_data_exists_response) {
580580
self->tokenList_.RemoveTask(id);
581581
if (!check_data_exists_response.IsSuccessful()) {

olp-cpp-sdk-dataservice-write/src/VolatileLayerClientImpl.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ client::CancellationToken VolatileLayerClientImpl::GetBaseVersion(
192192
"Operation cancelled.", true));
193193
};
194194

195-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
196195
auto getBaseVersion_callback =
196+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
197197
[=](MetadataApi::CatalogVersionResponse response) {
198198
self->tokenList_.RemoveTask(id);
199199
if (!response.IsSuccessful()) {
@@ -431,8 +431,8 @@ client::CancellationToken VolatileLayerClientImpl::GetBatch(
431431
"Operation cancelled.", true));
432432
};
433433

434-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
435434
auto getPublication_callback =
435+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
436436
[=](GetPublicationResponse getPublicationResponse) {
437437
self->tokenList_.RemoveTask(id);
438438
if (!getPublicationResponse.IsSuccessful()) {
@@ -588,8 +588,8 @@ client::CancellationToken VolatileLayerClientImpl::PublishToBatch(
588588
"Operation cancelled.", true));
589589
};
590590

591-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
592591
auto upload_partitions_callback =
592+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
593593
[=](UploadPartitionsResponse upload_partitions_response) {
594594
self->tokenList_.RemoveTask(id);
595595
if (!upload_partitions_response.IsSuccessful()) {
@@ -674,8 +674,8 @@ client::CancellationToken VolatileLayerClientImpl::CompleteBatch(
674674
"Operation cancelled.", true));
675675
};
676676

677-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
678677
auto completePublication_callback =
678+
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks): false
679679
[=](SubmitPublicationResponse submitPublicationResponse) {
680680
self->tokenList_.RemoveTask(id);
681681
if (!submitPublicationResponse.IsSuccessful()) {

0 commit comments

Comments
 (0)