Skip to content

Commit 68a1e9d

Browse files
ihsandemirihsandemir
authored
Fix inconsistent usage of environment variable character case (capital/small case) in workflow actions (#1379)
Inconsistent usage of environment variable character case (capital/small case) caused the tests not to run. Changed all the environment variables to be upper case. The tests should now work as expected in the builed including PR builder. Triggered a sample run [here](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/20297443182) for PR #1376 to test the changes. This run does not include the change to use RUN_TESTS=true in pr builder, hence, we should see that it still should not run the tests. In the second commit of the PR I enabled the RUN_TESTS=true in pr builder and triggered another workflow run [here](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/20297609221) where I run this PR #1379 and we should see the tests are run. As you can see, the tests are actually run e.g. [here](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/20297609221/job/58295008466) I had to force merge since it involves PR builder change.
1 parent 519f483 commit 68a1e9d

File tree

10 files changed

+38
-38
lines changed

10 files changed

+38
-38
lines changed

‎.github/actions/build-test/ubuntu-i386/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ runs:
9292
./scripts/install-thrift.sh ${{ inputs.THRIFT_VERSION }}
9393
9494
- name: Configure Resources
95-
if: ${{ inputs.run_tests == 'true' }}
95+
if: ${{ inputs.RUN_TESTS == 'true' }}
9696
shell: bash
9797
run: |
9898
ulimit -c unlimited

‎.github/actions/build-test/ubuntu-x86_64/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ runs:
5454
sudo ./scripts/install-thrift.sh ${{ inputs.THRIFT_VERSION }}
5555
5656
- name: Configure Resources
57-
if: ${{ inputs.run_tests == 'true' }}
57+
if: ${{ inputs.RUN_TESTS == 'true' }}
5858
shell: bash
5959
run: |
6060
ulimit -c unlimited

‎.github/actions/build-test/unix/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ runs:
4949
-DBUILD_EXAMPLES=OFF
5050
5151
- name: Test
52-
if: ${{ inputs.run_tests == 'true' }}
52+
if: ${{ inputs.RUN_TESTS == 'true' }}
5353
env:
5454
BUILD_DIR: build
5555
HAZELCAST_ENTERPRISE_KEY: ${{ inputs.HAZELCAST_ENTERPRISE_KEY }}

‎.github/actions/build-test/windows/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ runs:
150150
-DBUILD_EXAMPLES=OFF
151151
152152
- name: Test
153-
if: ${{ inputs.run_tests == 'true' }}
153+
if: ${{ inputs.RUN_TESTS == 'true' }}
154154
env:
155155
BUILD_DIR: build
156156
BUILD_CONFIGURATION: ${{ inputs.BUILD_TYPE }}

‎.github/actions/coverage-report/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ runs:
7272
-DBUILD_EXAMPLES=OFF
7373
7474
- name: Test
75-
if: ${{ inputs.run_tests == 'true' }}
75+
if: ${{ inputs.RUN_TESTS == 'true' }}
7676
env:
7777
BUILD_DIR: build
7878
HAZELCAST_ENTERPRISE_KEY: ${{ inputs.HAZELCAST_ENTERPRISE_KEY }}

‎.github/workflows/build-pr.yml‎

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ on:
2424
description: Enter guest PR verified HEAD commit SHA.
2525
required: true
2626
env:
27-
boost_version: 1.89.0
28-
boost_archive_name: 'boost_1_89_0.tar.gz'
29-
boost_folder_name: 'boost_1_89_0'
30-
boost_include_folder: 'C:\Boost\include\boost-1_89'
31-
boost_url: 'https://archives.boost.io/release/1.89.0/source/boost_1_89_0.tar.gz'
32-
thrift_version: 0.13.0
33-
run_tests: false
27+
BOOST_VERSION: 1.89.0
28+
BOOST_ARCHIVE_NAME: 'boost_1_89_0.tar.gz'
29+
BOOST_FOLDER_NAME: 'boost_1_89_0'
30+
BOOST_INCLUDE_FOLDER: 'C:\Boost\include\boost-1_89'
31+
BOOST_URL: 'https://archives.boost.io/release/1.89.0/source/boost_1_89_0.tar.gz'
32+
THRIFT_VERSION: 0.13.0
33+
RUN_TESTS: true
3434

3535
jobs:
3636

@@ -107,9 +107,9 @@ jobs:
107107
- uses: ./.github/actions/coverage-report
108108
with:
109109
GH_TOKEN: ${{ secrets.GH_TOKEN }}
110-
BOOST_VERSION: ${{ env.boost_version }}
111-
THRIFT_VERSION: ${{ env.thrift_version }}
112-
RUN_TESTS: ${{ env.run_tests }}
110+
BOOST_VERSION: ${{ env.BOOST_VERSION }}
111+
THRIFT_VERSION: ${{ env.THRIFT_VERSION }}
112+
RUN_TESTS: ${{ env.RUN_TESTS }}
113113
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
114114
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
115115
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -147,12 +147,12 @@ jobs:
147147
- uses: ./.github/actions/build-test/ubuntu-i386
148148
with:
149149
GH_TOKEN: ${{ secrets.GH_TOKEN }}
150-
BOOST_VERSION: ${{ env.boost_version }}
151-
THRIFT_VERSION: ${{ env.thrift_version }}
150+
BOOST_VERSION: ${{ env.BOOST_VERSION }}
151+
THRIFT_VERSION: ${{ env.THRIFT_VERSION }}
152152
BUILD_TYPE: ${{ matrix.build_type }}
153153
SHARED_LIBS_TOGGLE: ${{ matrix.shared_libs.toggle }}
154154
OPENSSL_TOGGLE: ${{ matrix.with_openssl.toggle }}
155-
RUN_TESTS: ${{ env.run_tests }}
155+
RUN_TESTS: ${{ env.RUN_TESTS }}
156156
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
157157
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
158158
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -183,12 +183,12 @@ jobs:
183183
- uses: ./.github/actions/build-test/ubuntu-x86_64
184184
with:
185185
GH_TOKEN: ${{ secrets.GH_TOKEN }}
186-
BOOST_VERSION: ${{ env.boost_version }}
187-
THRIFT_VERSION: ${{ env.thrift_version }}
186+
BOOST_VERSION: ${{ env.BOOST_VERSION }}
187+
THRIFT_VERSION: ${{ env.THRIFT_VERSION }}
188188
BUILD_TYPE: ${{ matrix.build_type }}
189189
SHARED_LIBS_TOGGLE: ${{ matrix.shared_libs.toggle }}
190190
OPENSSL_TOGGLE: ${{ matrix.with_openssl.toggle }}
191-
RUN_TESTS: ${{ env.run_tests }}
191+
RUN_TESTS: ${{ env.RUN_TESTS }}
192192
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
193193
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
194194
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -217,21 +217,21 @@ jobs:
217217
- uses: ./.github/actions/build-test/windows
218218
with:
219219
GH_TOKEN: ${{ secrets.GH_TOKEN }}
220-
BOOST_VERSION: ${{ env.boost_version }}
221-
THRIFT_VERSION: ${{ env.thrift_version }}
220+
BOOST_VERSION: ${{ env.BOOST_VERSION }}
221+
THRIFT_VERSION: ${{ env.THRIFT_VERSION }}
222222
BUILD_TYPE: ${{ matrix.build_type }}
223223
SHARED_LIBS_TOGGLE: ${{ matrix.shared_libs.toggle }}
224224
OPENSSL_TOGGLE: ${{ matrix.with_openssl.toggle }}
225225
ARCH_CHOCO_OPTIONS: ${{ matrix.options.choco_options }}
226226
ARCH_ADDRESS_MODEL: ${{ matrix.options.address_model }}
227227
ARCH_CMAKE: ${{ matrix.options.cmake }}
228228
INSTALL_BOOST: true
229-
BOOST_URL: ${{ env.boost_url }}
230-
BOOST_ARCHIVE_NAME: ${{ env.boost_archive_name }}
231-
BOOST_FOLDER_NAME: ${{ env.boost_folder_name }}
232-
BOOST_INCLUDE_FOLDER: ${{ env.boost_include_folder }}
229+
BOOST_URL: ${{ env.BOOST_URL }}
230+
BOOST_ARCHIVE_NAME: ${{ env.BOOST_ARCHIVE_NAME }}
231+
BOOST_FOLDER_NAME: ${{ env.BOOST_FOLDER_NAME }}
232+
BOOST_INCLUDE_FOLDER: ${{ env.BOOST_INCLUDE_FOLDER }}
233233
INSTALL_THRIFT: true
234-
RUN_TESTS: ${{ env.run_tests }}
234+
RUN_TESTS: ${{ env.RUN_TESTS }}
235235
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
236236
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
237237
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -263,11 +263,11 @@ jobs:
263263
- uses: ./.github/actions/build-test/macos-x86_64
264264
with:
265265
GH_TOKEN: ${{ secrets.GH_TOKEN }}
266-
BOOST_VERSION: ${{ env.boost_version }}
266+
BOOST_VERSION: ${{ env.BOOST_VERSION }}
267267
BUILD_TYPE: ${{ matrix.build_type }}
268268
SHARED_LIBS_TOGGLE: ${{ matrix.shared_libs.toggle }}
269269
OPENSSL_TOGGLE: ${{ matrix.with_openssl.toggle }}
270-
RUN_TESTS: ${{ env.run_tests }}
270+
RUN_TESTS: ${{ env.RUN_TESTS }}
271271
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
272272
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
273273
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

‎.github/workflows/nightly-macos-x86_64.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: nightly-macOS-x86_64
33
on:
44
workflow_dispatch:
55
inputs:
6-
run_tests:
6+
RUN_TESTS:
77
type: boolean
88
description: Enable/Disable test stage
99
default: true
@@ -45,7 +45,7 @@ jobs:
4545
BUILD_TYPE: ${{ matrix.build_type }}
4646
SHARED_LIBS_TOGGLE: ${{ matrix.shared_libs.toggle }}
4747
OPENSSL_TOGGLE: ${{ matrix.with_openssl.toggle }}
48-
RUN_TESTS: ${{ inputs.run_tests || github.event_name == 'schedule' }}
48+
RUN_TESTS: ${{ inputs.RUN_TESTS || github.event_name == 'schedule' }}
4949
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
5050
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
5151
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

‎.github/workflows/nightly-ubuntu-i386.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: nightly-Ubuntu-i386
33
on:
44
workflow_dispatch:
55
inputs:
6-
run_tests:
6+
RUN_TESTS:
77
type: boolean
88
description: Enable/Disable test stage
99
default: true
@@ -47,7 +47,7 @@ jobs:
4747
BUILD_TYPE: ${{ matrix.build_type }}
4848
SHARED_LIBS_TOGGLE: ${{ matrix.shared_libs.toggle }}
4949
OPENSSL_TOGGLE: ${{ matrix.with_openssl.toggle }}
50-
RUN_TESTS: ${{ inputs.run_tests || github.event_name == 'schedule' }}
50+
RUN_TESTS: ${{ inputs.RUN_TESTS || github.event_name == 'schedule' }}
5151
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
5252
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
5353
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

‎.github/workflows/nightly-ubuntu-x86_64.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: nightly-Ubuntu-x86_64
33
on:
44
workflow_dispatch:
55
inputs:
6-
run_tests:
6+
RUN_TESTS:
77
type: boolean
88
description: Enable/Disable test stage
99
default: true
@@ -56,7 +56,7 @@ jobs:
5656
BUILD_TYPE: ${{ matrix.build_type }}
5757
SHARED_LIBS_TOGGLE: ${{ matrix.shared_libs.toggle }}
5858
OPENSSL_TOGGLE: ${{ matrix.with_openssl.toggle }}
59-
RUN_TESTS: ${{ inputs.run_tests || github.event_name == 'schedule' }}
59+
RUN_TESTS: ${{ inputs.RUN_TESTS || github.event_name == 'schedule' }}
6060
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
6161
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
6262
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

‎.github/workflows/nightly-windows.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: nightly-Windows
33
on:
44
workflow_dispatch:
55
inputs:
6-
run_tests:
6+
RUN_TESTS:
77
type: boolean
88
description: Enable/Disable test stage
99
default: true
@@ -82,7 +82,7 @@ jobs:
8282
BOOST_FOLDER_NAME: ${{ matrix.vc_boost.boost_folder_name }}
8383
BOOST_INCLUDE_FOLDER: ${{ matrix.vc_boost.boost_include_folder }}
8484
INSTALL_THRIFT: ${{ steps.cache-thrift.outputs.cache-hit != 'true' }}
85-
RUN_TESTS: ${{ inputs.run_tests || github.event_name == 'schedule' }}
85+
RUN_TESTS: ${{ inputs.RUN_TESTS || github.event_name == 'schedule' }}
8686
HAZELCAST_ENTERPRISE_KEY: ${{ secrets.HAZELCAST_ENTERPRISE_KEY }}
8787
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
8888
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

0 commit comments

Comments
 (0)