Skip to content

Commit 301484b

Browse files
authored
fix: make RC logs visible in Windows GitHub Actions [HZ-5387] (#1414)
Use `start /B` instead of `start /MIN cmd /c` so RC stdout/stderr appear in the same console — visible in CI in real-time. Replace taskkill window-title filter with wmic command-line match since `start /B` does not create a titled window. replaces #1413
1 parent 6a064f9 commit 301484b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

scripts/start-rc.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,4 +82,4 @@ set CLASSPATH="hazelcast-remote-controller-%HAZELCAST_RC_VERSION%.jar;hazelcast-
8282
echo "Starting Remote Controller ... enterprise ...Using classpath: %CLASSPATH%"
8383

8484
echo "Starting hazelcast-remote-controller"
85-
start "hazelcast-remote-controller" /MIN cmd /c "java -Dhazelcast.enterprise.license.key=%HAZELCAST_ENTERPRISE_KEY% -Dhazelcast.phone.home.enabled=false -cp %CLASSPATH% com.hazelcast.remotecontroller.Main --use-simple-server"
85+
start /B java -Dhazelcast.enterprise.license.key=%HAZELCAST_ENTERPRISE_KEY% -Dhazelcast.phone.home.enabled=false -cp %CLASSPATH% com.hazelcast.remotecontroller.Main --use-simple-server

scripts/test-windows.bat

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ echo "Waiting for the test server to start. Timeout: %timeout% seconds"
4141

4242
:server_failed_to_start
4343
echo "The test server did not start in %RC_START_TIMEOUT_IN_SECS% seconds. Test FAILED."
44-
call taskkill /F /FI "WINDOWTITLE eq hazelcast-remote-controller"
44+
wmic process where "commandline like '%%com.hazelcast.remotecontroller.Main%%'" call terminate >nul 2>&1
4545
exit /b 1
4646

4747
:server_started
@@ -63,6 +63,6 @@ echo %TEST_EXECUTABLE%
6363
%TEST_EXECUTABLE% --gtest_output="xml:CPP_Client_Test_Report.xml"
6464
set result=%errorlevel%
6565

66-
taskkill /T /F /FI "WINDOWTITLE eq hazelcast-remote-controller"
66+
wmic process where "commandline like '%%com.hazelcast.remotecontroller.Main%%'" call terminate >nul 2>&1
6767

6868
exit /b %result%

0 commit comments

Comments
 (0)