Removed individual warning suppressions in each file for C4251 [HZ-5297] (#1387)

Removed individual warning suppressions in each file for C4251 dll
export warning in wondows and put a global suppression in Cmake file to
suppress it for the project wide.

It is OK to disable this warning project wise, because it means warnings
about unexported fields such as std::vector in a class but it is not
important because our users will compile from source code and hence they
will always use the same e.g. `std::vector` versions.

This makes less code lines for the project and remove the unneeded
repetitions.

Author: ihsandemir

CMakeLists.txt

@@ -158,6 +158,8 @@ message(STATUS "CMAKE_CXX_COMPILER_ID = ${CMAKE_CXX_COMPILER_ID}")
 # MSVC-specific compiler flags
 if (MSVC)
     target_compile_options(${PROJECT_NAME} PRIVATE /bigobj)
+    # suppress warning about DLL-interface dll export, users do import but we export in library.
+    target_compile_options(${PROJECT_NAME} PRIVATE /wd4251 /wd4275)
 endif ()
 
 # AppleClang-specific compiler flags, we set for all targets since we want these flags also for tests and examples

hazelcast/include/hazelcast/client/address.h

@@ -22,11 +22,6 @@
 #include <string>
 #include <iosfwd>
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 namespace client {
 
@@ -118,7 +113,3 @@ struct HAZELCAST_API hash<hazelcast::client::address>
       const hazelcast::client::address& address) const noexcept;
 };
 } // namespace std
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/aws/aws_client.h

@@ -21,11 +21,6 @@
 #include "hazelcast/util/export.h"
 #include "hazelcast/client/address.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 class logger;
 
@@ -57,7 +52,3 @@ class HAZELCAST_API aws_client
 } // namespace aws
 } // namespace client
 } // namespace hazelcast
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/aws/impl/Constants.h

@@ -17,11 +17,6 @@
 
 #include "hazelcast/util/export.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 namespace client {
 namespace aws {
@@ -38,7 +33,3 @@ struct HAZELCAST_API Constants
 } // namespace aws
 } // namespace client
 } // namespace hazelcast
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/aws/impl/DescribeInstances.h

@@ -23,11 +23,6 @@
 #include "hazelcast/client/aws/security/ec2_request_signer.h"
 #include "hazelcast/util/SyncHttpsClient.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 class logger;
 
@@ -97,7 +92,3 @@ class HAZELCAST_API DescribeInstances
 } // namespace aws
 } // namespace client
 } // namespace hazelcast
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/aws/impl/Filter.h

@@ -20,11 +20,6 @@
 
 #include "hazelcast/util/export.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 namespace client {
 namespace aws {
@@ -56,7 +51,3 @@ class HAZELCAST_API Filter
 } // namespace aws
 } // namespace client
 } // namespace hazelcast
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/aws/security/ec2_request_signer.h

@@ -21,11 +21,6 @@
 
 #include "hazelcast/util/export.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 namespace client {
 namespace config {
@@ -117,7 +112,3 @@ class HAZELCAST_API ec2_request_signer
 } // namespace aws
 } // namespace client
 } // namespace hazelcast
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/aws/utility/aws_url_encoder.h

@@ -19,11 +19,6 @@
 
 #include "hazelcast/util/export.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 namespace client {
 namespace aws {
@@ -40,7 +35,3 @@ class HAZELCAST_API aws_url_encoder
 } // namespace aws
 } // namespace client
 } // namespace hazelcast
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/aws/utility/cloud_utility.h

@@ -21,11 +21,6 @@
 
 #include "hazelcast/util/export.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace pt = boost::property_tree;
 
 namespace hazelcast {
@@ -64,7 +59,3 @@ class HAZELCAST_API cloud_utility
 } // namespace aws
 } // namespace client
 } // namespace hazelcast
-
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif

hazelcast/include/hazelcast/client/big_decimal.h

@@ -19,11 +19,6 @@
 #include <boost/multiprecision/cpp_int.hpp>
 #include "hazelcast/util/export.h"
 
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(push)
-#pragma warning(disable : 4251) // for dll export
-#endif
-
 namespace hazelcast {
 namespace client {
 /**
@@ -102,6 +97,3 @@ to_bytes(const boost::multiprecision::cpp_int& i);
 } // namespace pimpl
 } // namespace client
 } // namespace hazelcast
-#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
-#pragma warning(pop)
-#endif