test fixture

Author: mnafees

sdks/python/hatchet_sdk/opentelemetry/instrumentor.py

@@ -258,17 +258,23 @@ class HatchetInstrumentor(BaseInstrumentor):  # type: ignore[misc]
     The instrumentor provides an OpenTelemetry integration for Hatchet by setting up
     tracing and metrics collection.
 
-    :param tracer_provider: TracerProvider | None: The OpenTelemetry TracerProvider to use.
+    :param tracer_provider: The OpenTelemetry TracerProvider to use.
             If not provided and `enable_hatchet_otel_collector` is True, a new SDKTracerProvider
             will be created. Otherwise, the global tracer provider will be used.
-    :param meter_provider: MeterProvider | None: The OpenTelemetry MeterProvider to use.
+    :param meter_provider: The OpenTelemetry MeterProvider to use.
             If not provided, a no-op meter provider will be used.
-    :param config: ClientConfig | None: The configuration for the Hatchet client. If not provided,
+    :param config: The configuration for the Hatchet client. If not provided,
             a default configuration will be used.
-    :param enable_hatchet_otel_collector: bool: If True (the default), adds an OTLP exporter
+    :param enable_hatchet_otel_collector: If True (the default), adds an OTLP exporter
             to send traces to the Hatchet engine. Uses the same connection settings (host, TLS,
             token) as the Hatchet client. This can be combined with your own tracer_provider to
             send traces to multiple destinations (e.g., both Hatchet and Jaeger/Datadog).
+    :param schedule_delay_millis: The delay in milliseconds between two consecutive
+            exports of the BatchSpanProcessor. Defaults to the OTel SDK default (5000ms) if not set.
+    :param max_export_batch_size: The maximum batch size for the BatchSpanProcessor.
+            Defaults to the OTel SDK default (512) if not set.
+    :param max_queue_size: The maximum queue size for the BatchSpanProcessor.
+            Defaults to the OTel SDK default (2048) if not set.
 
     Example usage::
 

sdks/python/tests/otel_traces/test_otel_traces.py

@@ -116,37 +116,29 @@ async def test_otel_traces_on_retry(
 
     spans = _get_trace_spans(hatchet, ref.workflow_run_id)
 
-    # Both the failed first attempt and the successful retry should have spans
+    # The DB query returns only spans for the latest retry (MAX retry_count),
+    # so we expect exactly the successful retry's span.
     step_run_spans = [s for s in spans if s.get("spanName") == "hatchet.start_step_run"]
-    assert len(step_run_spans) >= 2, (
-        f"Expected at least 2 hatchet task run spans (initial + retry), "
+    assert len(step_run_spans) >= 1, (
+        f"Expected at least 1 hatchet task run span for the successful retry, "
         f"got {len(step_run_spans)}. All spans: {[s.get('spanName') for s in spans]}"
     )
 
-    # The first attempt should have errored
-    error_spans = [s for s in step_run_spans if s.get("statusCode") == "ERROR"]
-    assert len(error_spans) >= 1, (
-        f"Expected at least one ERROR span from the failed first attempt. "
-        f"Statuses: {[s.get('statusCode') for s in step_run_spans]}"
+    # The returned span should be from the successful retry (retryCount >= 1)
+    latest_span = step_run_spans[0]
+    assert latest_span.get("retryCount", 0) >= 1, (
+        f"Expected span from retry attempt (retryCount >= 1), "
+        f"got retryCount={latest_span.get('retryCount')}"
     )
 
-    # All step run spans should have valid hatchet.* attributes
-    for span in step_run_spans:
-        attrs = span.get("spanAttributes", {})
-        assert (
-            "hatchet.step_run_id" in attrs
-        ), f"Step run span missing hatchet.step_run_id. Attrs: {attrs}"
-        assert (
-            "hatchet.workflow_run_id" in attrs
-        ), f"Step run span missing hatchet.workflow_run_id. Attrs: {attrs}"
-        assert (
-            "hatchet.tenant_id" in attrs
-        ), f"Step run span missing hatchet.tenant_id. Attrs: {attrs}"
-
-    # Verify retry count differs between attempts
-    retry_counts = [
-        s.get("spanAttributes", {}).get("hatchet.retry_count") for s in step_run_spans
-    ]
+    # The span should have valid hatchet.* attributes
+    attrs = latest_span.get("spanAttributes", {})
+    assert (
+        "hatchet.step_run_id" in attrs
+    ), f"Step run span missing hatchet.step_run_id. Attrs: {attrs}"
+    assert (
+        "hatchet.workflow_run_id" in attrs
+    ), f"Step run span missing hatchet.workflow_run_id. Attrs: {attrs}"
     assert (
-        len(set(retry_counts)) >= 2
-    ), f"Expected different retry_count values across attempts, got {retry_counts}"
+        "hatchet.tenant_id" in attrs
+    ), f"Step run span missing hatchet.tenant_id. Attrs: {attrs}"