forked from ibm-power-utilities/powerpc-utils
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathChangelog
More file actions
1457 lines (1008 loc) · 55.8 KB
/
Changelog
File metadata and controls
1457 lines (1008 loc) · 55.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
powerpc-utils-1.3.2
=====================================================================
commit 4e5b9dacf7bbddfb58269fc50de6586a9ac6fdfd
Author: Ulrich Weigand <[email protected]>
Date: Mon Jul 11 17:13:17 2016 -0400
lparstat: Fix computation of time used in statistics
The routine get_time computes bogus timestap values due to confusing
seconds and microseconds. This leads to incorrect return values from
elapsed_time and therefore incorrect values for the physc field.
Fixed by converting the "time" sysentry field to microseconds (and
computing it correctly), and updating the user of elapsed_time.
In addition, %entc is supposed to show the ratio of physc to the
number of entitled CPUs as *percentage*, so the ratio needs to be
multiplied by 100.
Signed-off-by: Ulrich Weigand <[email protected]>
Signed-off-by: Michael Bringmann <[email protected]>
commit a97c5664f53f9a18dd0b941a842d7884253cf8ed
Author: Nathan Fontenot <[email protected]>
Date: Mon Jul 11 17:06:26 2016 -0400
drmgr: Disable use of in-kernel cpu hotplug
After submitting the patch to update drmgr to use the in-kernel hotplug
capabilities for memory and cpu, commit <bbc5fc07c54d> (drmgr: Start using
in-kernel DLPAR functionality for cpu/memory), I realized there
are still distro kernels that do not have the in-kernel cpu hotplug
capabilities. Using the latest drmgr with this update breaks cpu dlpar
because the cpu dlpar code assumes that if the dlpar sysfs file exists
then in-kernel cpu dlpar is possible. this is wrong, the sysfs dlpar file
was added with in-kernel memory hotplug, its existence can only guarantee
memory hotplug capability.
For now, disable using the in-kernel cpu capabilities by drmgr until
this can be resolved.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 2bb7599d702d4e1de1ff0f9cbe53329e59c4e120
Author: Ian Neal <[email protected]>
Date: Mon Jul 11 10:02:45 2016 -0400
lparstat: flush data to stdout
The stdout stream is not being flushed after being written to. This
means that it doesn't behave properly in shell pipelines as the data
isn't visible until the program exits. The fix is to simply flush
after writes so the data is immediately available to other processes
in the pipeline.
Signed-off-by: Ian Neal <[email protected]>
commit c3269d4e3d4882fd931d1df6aece0bec86fb6734
Author: Vasant Hegde <[email protected]>
Date: Thu Jun 30 10:26:58 2016 -0400
update_flash: Fix bashism issue in opp_display_current_fw_version()
Ubuntu uses dash, not bash. We hit below warning on Ubuntu system.
root@abc:/sys/firmware/devicetree/base/ibm,opal/sensors# update_flash -d
/usr/sbin/update_flash_nv: 595: [: x43: unexpected operator
Firmware version:
....
....
== is a bashism. Replace it with =.
Fixes: 767e3dd7 (update_flash: Add support for OpenPower system)
Signed-off-by: Vasant Hegde <[email protected]>
commit 386a07c4dc6c09d35116dc6064f7a83d76f4415b
Author: Nathan Fontenot <[email protected]>
Date: Tue May 24 16:32:39 2016 -0400
errinjct: Correct read_file() error checking
When reading files from syfs the file length returned from a stat()
call does not always match the actual length of the file. The read_file()
routine should be checking for an error return from the read() call
instead of checking that the amount read matches the file length returned
from a stat() call.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 42b83884bfb51c0c8b23bf2949157430f8468caa
Author: Nathan Fontenot <[email protected]>
Date: Tue May 24 16:31:37 2016 -0400
errinjct: Recognize -5 return from rtas
Update the errinjct command to recognize the rturn code of -5 from
rtas indicating that PCI error injection is not enabled.
Signed-off-by: Nathan Fontenot <[email protected]>
commit ab848a8d5cc4c4b9f5faef1b31be3982fb7d4bf2
Author: Nathan Fontenot <[email protected]>
Date: Tue May 24 16:30:33 2016 -0400
errinjct: Correct config_addr parsing
A recent patch (commit id: ccc9c72cec2a4) to move the errinjct function to
using a common read_file() routine did not correctly update the
get_config_addr_from_reg() function. This patch corrects this to return the
proper config address.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 9fc079cf39d999040483a00d3b41000ca3e43013
Author: John Allen <[email protected]>
Date: Tue May 24 16:28:27 2016 -0400
drmgr: Workaround for concurrent PRRN collisions
Proposed workaround for issues with current PRRN event handling mechanism.
Currently, the mechanism works by kicking off a script that calls a drmgr
remove followed by a drmgr add for each effected device. With this method,
problems can occur when multiple prrn events arrive in a short time span or
when other dlpar operations are happening while the script is running. What
can happen is that these other dlpar operations can jump in inbetween when
the script calls the remove and the add and take the drmgr lock. Then when
we try to add the memory back from the script, we are unable to take the
drmgr lock and the add fails.
This patch fixes this issue by creating a new -P flag for drmgr which will
perform the necessary removes/adds from within the drmgr lock. The new
option will be invoked as follows:
drmgr -P <path to prrn log file>
On the rtas_errd side, we will begin by creating a log file for the
PRRN event which will contain a list of the type and the drc index for
each effected device. Then instead of invoking the script, we will call
the above drmgr command with the path to the prrn log file. Then, on the
drmgr side, we parse the list and perform the necessary removes/adds and
then delete the prrn log file.
Signed-off-by: John Allen <[email protected]>
commit bbc5fc07c54dd53f4ceac3552ea12717cc86cba2
Author: Nathan Fontenot <[email protected]>
Date: Wed May 11 13:16:19 2016 -0400
drmgr: Start using in-kernel DLPAR functionality for cpu/memory
Now that the capability to do DLPAR of cpus and memory can be
done completely in the kernel, update the drmgr command to use
this functionality.
The kernel updates provided a sysfs file (/sys/kernel/dlpar)
that will allow the drmgr command invoke DLPAR of cpus and memory
by writing to this file.
There are some exisitng behaviors of drmgr on the PowerVM platforms
that require cpu and memory to be done slightly differently. For
memory drmgr only needs to report the number of LMBs that were
added or removed so drmgr can just pass all requests straight to
the kernel. This patch also makes a common routine for reporting
memory resources to ensure the format is kept constant.
For cpu DLPAR the drmgr command has to report the drc name of each
cpu that is added/removed. To do this the command uses much of the
same device tree parsing that is currently used and make a request
to the kernel to remove a specific cpu (by drc index) where a
write to the sysfs probe file was previously done.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 4dafa57ec7c1498f94b324e671625b0794b92f2f
Author: Thomas Falcon <[email protected]>
Date: Tue Apr 19 15:01:13 2016 -0400
ppc64_cpu: display error message after set_smt_state_one failure
This avoids a silent error if threads are unable to be onlined or offlined.
Signed-off-by: Thomas Falcon <[email protected]>
commit 96745e9e1cb560af6f900b1dac920e36db750ee5
Author: John Allen <[email protected]>
Date: Tue Apr 19 14:52:35 2016 -0400
lparstat: Check return value of fopen/popen before dereferencing
Checks the return value of fopen and popen in several locations to make sure
it's not null. If we pass a null file descriptor to fgets, we will hit a
segfault.
Signed-off-by: John Allen <[email protected]>
Reviewed-by: Vasant Hegde <[email protected]>
commit 6855b92b3f9f3ed9c02065344cc98b965c3f03ef
Author: Michael Roth <[email protected]>
Date: Tue Apr 19 14:49:43 2016 -0400
drmgr: avoid loading rpadlpar_io/rpaphp when -v flags is used
The -v / opts->pci_virtio flag was added to provide an alternative way
to scan/remove PCI devices which doesn't rely on rpaphp. That was a
workaround for a bug induced by QEMU emulating PHBs with multiple
hotpluggable slots, which fails to register slots beyond the first due
to rpaphp no longer accounting for the possibility of there being more
than 1 slot per PHB. This leads to warnings of the form:
kernel: rpaphp: pci_hp_register failed with error -16
kernel: rpaphp: pci_hp_register failed with error -16
...
For most guest distros this has resulted in the module not being
loaded by default to avoid the errors showing up.
However, as of a9b4e4e, we now load automatically load the module as
needed, but we don't take opts->pci_virtio into account when
determining if it's needed, leading to PCI hotplug operations to
KVM guests now resulting into rpaphp being loaded and
generating the errors above when drmgr is invoked.
Fix this by avoiding modprobe of rpadlpar_io/rpaphp when
opts->pci_virtio is set.
Signed-off-by: Michael Roth <[email protected]>
commit efa87d93231eb0fe4f406bf58e7d5aa783ee4f13
Author: Michael Bringmann <[email protected]>
Date: Tue Apr 19 14:47:32 2016 -0400
lparstat: Correct presentation of some stats
lparstat.c: Currently there are several problems with the presentation
of statistics by lparstat's default output mode. These issues include:
* Showing negative values for certain fields e.g. %user, %sys, %wait,
%lbusy.
* Showing zero values for certain fields e.g. physc, %entc
* Identifying systems with 'Shared' or 'Dedicated' Memory Mode
* Calculating the number if logical CPUs used by a system
This patch looks to correct these issues. It also changes the widths
of the physc, %entc fields which had too little precision available
to show the value change on some systems.
Signed-off-by: Michael Bringmann <[email protected]>
commit a27c639aca69271aabe7cac287f998b29b82f333
Author: Michael Roth <[email protected]>
Date: Tue Apr 19 14:37:36 2016 -0400
drmgr: ensure PCI cleanup is done before offlining dev
As part of 4f542616, functionality was added to support add/remove
PCI devices without relying on rpaphp hotplug module. The sysfs
write used in the remove path initiates an asynchronous removal of
PCI device from kernel PCI subsystem, and eventually from the sysfs
tree. Afterward, we set the corresponding DRC for the device to
ISOLATED state so host can complete device removal.
To avoid the situation where the asychronous removal has not yet
completed by the time drmgr sets the state to ISOLATED, and simple
sleep of 3 seconds was added. This seems to have worked out okay
for virtio devices, but in the case of other devices, like PCI
passthrough of a Mellanox CX4 virtual function, the removal can take
up to 20 seconds.
When this happens, we hit a situation where the host reclaims the
devices while the guest is still attempting to access it in it's
cleanup path, which leads to guest crashes.
Fix this by polling the PCI devices sysfs path and not completing
the removal until the sysfs path is removed as part of device cleanup.
Signed-off-by: Michael Roth <[email protected]>
powerpc-utils-1.3.1
=====================================================================
commit dccad2d1dc5c84571f31af3117095bd9ec6e34c4
Author: Brahadambal Srinivasan <[email protected]>
Date: Fri Mar 25 07:46:56 2016 -0400
snap: PowerNV platform is not correctly checked
Recent patches to change from PowerKVM to PowerNV missed a
simple change to the /usr/sbin/snap script. This patch is to
fix that.
Signed-off-by: Brahadambal Srinivasan <[email protected]>
commit a9b4e4ed7c6a908feb04f5b066f214ad14c76745
Author: Nathan Fontenot <[email protected]>
Date: Fri Mar 25 07:45:20 2016 -0400
drmgr: Load kernel modules for pci hotplug
For PHB DLPAR, slot DLPAR, and PCI hotplug operations we need to ensure
that the rpadlpar_io and rpaphp kernel modules are loaded or have been
built into the kernel. A check for this is currently done for PHB and
slot DLPAR when determining if the system is capable of these operations.
This patch moves the code to validate the presence of these modules
to be called from dr_init() for PHB/SLOT/PCI operations. In order
to do this the parsing of args has to be done prior to calling dr_init.
This should not cause an issue since we can parse args without holding
the dr_lock and any errors are written to stderr.
Signed-off-by: Nathan Fontenot <[email protected]>
commit c66dfa6338e6bb889f4806df1518642a800992ea
Author: John Allen <[email protected]>
Date: Fri Mar 25 07:43:39 2016 -0400
lsslot: Update man page/usage statement to document required argument
Update man page and usage statement for lsslot to reflect the fact that
the -d flag requires an argument.
Signed-off-by: John Allen <[email protected]>
commit bd7e19a9ff5aebe741b0520906660dac1ecf4a2a
Author: Nathan Fontenot <[email protected]>
Date: Fri Mar 25 07:27:58 2016 -0400
nvram: Correct valid partition name checking
A recent update to not allow long names had a bug in that it did
not correctly check the return value when verifying a partition name.
Fixes: b15b0a7f9ffc (nvram: don't allow long names)
Signed-off-by: Nathan Fontenot <[email protected]>
CC: Joel Stanley <[email protected]>
commit 63a362d28253e32552ff3e1e4358bfb47d69c78b
Author: Mauricio Faria de Oliveira <[email protected]>
Date: Thu Mar 17 20:01:06 2016 -0400
ofpathname: Convert OF device path to logical device path for NVMe devices
Add support to convert a Open Firmware device path to logical device path
for NVMe devices (with namespace id).
Signed-off-by: Mauricio Faria de Oliveira <[email protected]>
commit bd0a574f70f2b2af39020440e6e3ed61ab5afe35
Author: Mauricio Faria de Oliveira <[email protected]>
Date: Thu Mar 17 19:59:51 2016 -0400
ofpathanme: Convert logical device path to OF device path for NVMe devices
Add support to convert logical device path to Open firmware device path
for NVMe devices.
Signed-off-by: Mauricio Faria de Oliveira <[email protected]>
commit e4af95a7da425d37a6762b81d1614e648129b36a
Author: Nathan Fontenot <[email protected]>
Date: Tue Feb 23 14:43:35 2016 -0500
drmgr: free allocated hpdev in error path
In error paths while allocating hpdevs in get_os_hp_devices() we
can exit without free'ing an allocated hpdev. Move up the addition
of the hpdev to the hpdev_list to ensure it is free'ed if an error
occurs.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 6fcff4b41726784d9f13bdc905d7eb85f84a3248
Author: Nathan Fontenot <[email protected]>
Date: Tue Feb 23 12:18:12 2016 -0500
drmgr: close opened dir
Close the directory we are traversing before returning.
Signed-off-by: Nathan Fontenot <[email protected]>
commit faa441c184dfa28bd5793adbd17faa7f696fc49d
Author: Nathan Fontenot <[email protected]>
Date: Tue Feb 23 12:17:03 2016 -0500
rtas_dbg: Do not exit on failure to read rtas token
When gathering a list of the available rtas tokens if we are not able
to determine the rtas token value for a token in the device tree we
should print an error message and continue instead of exiting.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 64dd69fdc6242ec22519f1d2a18f1328825add3e
Author: Nathan Fontenot <[email protected]>
Date: Tue Feb 23 12:15:53 2016 -0500
rtas_dbg: Ensure we NULL terminate token names
The current code to look up rtas tokens writes the token name
to a static buffer size, this runs the risk of not having the
string null terminated if the string length matches the buffer
length.
Update the code to use strdup so we can ensure the strings are
null terminated. This also updates the free_rtas_tokens()
routine to free the token name.
Signed-off-by: Nathan Fontenot <[email protected]>
commit ccc9c72cec2a4885a219958c69c35abae6cef9c4
Author: Nathan Fontenot <[email protected]>
Date: Tue Feb 23 12:14:16 2016 -0500
errinjct: Correct possible buffer overflow
In multiple places in the errinjct command we read the contents of
a file into a local buffer. This presents a possible issue if the
file we are reading ever exceeds the size of the buffer. To prevent
this issue a new read_file() routine is introduced that will
allocate a buffer large enough to hold the contents of the file and
read the file into the buffer.
Signed-off-by: Nathan Fontenot <[email protected]>
commit fa50467bbf0f83207055124e7bee866cbc1b612c
Merge: 39dbb91 61558c9
Author: Nathan Fontenot <[email protected]>
Date: Mon Feb 15 09:03:26 2016 -0500
Merge branch 'cyphermox-mpath' into next
commit 61558c9df4571b79c435e2d7b1157f40ae7565a3
Merge: 39dbb91 2d27304
Author: Mathieu Trudel-Lapierre <[email protected]>
Date: Mon Feb 15 08:51:37 2016 -0500
ofpathanme: map mpath* devices to the appropriate dm-* generic dm device
Signed-off-by: Mathieu Trudel-Lapierre <[email protected]
commit 39dbb91904e0b94aa5a665d5f84dec736fdbbb07
Author: Nathan Fontenot <[email protected]>
Date: Mon Feb 1 11:59:27 2016 -0500
errinjct: Close file descriptors
Properly handle file descriptors opened by ensuring
they are closed prior to returning. Reported as a
leaked resource by Coverity scans.
Signed-off-by: Nathan Fontenot <[email protected]>
Reviewed-by: Vasant Hegde <[email protected]>
commit 07c190715a730dc98823691f18aa3b262a2bf432
Author: Nathan Fontenot <[email protected]>
Date: Mon Feb 1 11:57:49 2016 -0500
errinjct: Null terminate buffer from read()
Null terminate buffers filled when calling read(). Issue uncovered
with Coverity Scans.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 3153111b0ab6e6ae2b83c448443a3b6e3e8fe6e5
Author: Nathan Fontenot <[email protected]>
Date: Mon Feb 1 11:56:02 2016 -0500
activate_firmware: Remove use of strcat
Resolve uninitialized scalar variable reported by Coverity scan.
The 'msg' buffer was being used uninitialized in calls to strcat,
this patch removes the use of the local 'msg' variable and puts
the message string directly in the warnx() call.
Signed-off-by: Nathan Fontenot <[email protected]>
Reviewed-by: Vasant Hegde <[email protected]>
commit f3f25d4aee3f12f0dfc6611aaab6f0819d58fe33
Author: Nathan Fontenot <[email protected]>
Date: Mon Feb 1 11:53:13 2016 -0500
ppc64_cpu: free core_state on error
Make sure we free the allocated 'core_state', issue found with Coverity.
Signed-off-by: Nathan Fontenot <[email protected]>
commit e6f476d32c33f5b8e364f930c467785495eeb0ce
Author: Nathan Fontenot <[email protected]>
Date: Mon Feb 1 11:51:55 2016 -0500
lsslot: free lmb_list on error
Free the lmb resources allocated by lsslot, Issue discovered with
Coverity scan.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 2d27304b9e8f69619927cd2f55fb1c11c3dc5f09
Author: Mathieu Trudel-Lapierre <[email protected]>
Date: Tue Jan 12 16:46:12 2016 -0500
ofpathname: map mpath* devices to the appropriate dm-* generic dm device.
Signed-off-by: Mathieu Trudel-Lapierre <[email protected]>
powerpc-utils-1.3.0
=====================================================================
commit ad4cf85f4bc80f6f5cbf4ce0b71eada696848081
Author: Nathan Fontenot <[email protected]>
Date: Thu Jan 7 15:17:41 2016 -0500
Move the powerpc-utils package from the IBM license to the GNU GPL license.
Signed-off-by: Nathan Fontenot <[email protected]>
commit f037afe3bcece02ca3a3b1711a57c66db088cfa1
Author: Nathan Fontenot <[email protected]>
Date: Tue Dec 1 16:36:11 2015 -0500
drmgr: Correct checking for display adapters when adding PHB
A previous commit (c2091227) added formalization for checking for display
adapters. Unfortunately the update tries to verify if there is a display
adapter for a NULL phb pointer when trying to add a PHB resulting in a
segfault on phb add requests.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 85a5037cb01c1aaa5ad3dbd91f74dbcdd823dbb1
Author: Nathan Fontenot <[email protected]>
Date: Tue Dec 1 16:35:04 2015 -0500
drmgr: Remove extraneous debug output
Remove extra debug statements for allocating and free'ing drc information.
These were mistakenly left in during debug of a previous patch.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 33aa48a0c4ebc4e660080514939232ad2912cb6d
Author: Nathan Fontenot <[email protected]>
Date: Tue Dec 1 16:33:45 2015 -0500
drmgr: Fix node add buffer overflow
When adding a node to the device tree, the drmgr command writes a terminatin
null in the first character past the end of the allocated buffer. This
results in a SIGABRT being generated by libc when the buffer is free'ed.
The fix is to move the writing of the space between properties to the
beginning of the loop instead of at the end of the loop.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 55544a975f87e9d76366e6fefcf571ae01f3e7eb
Author: Nathan Fontenot <[email protected]>
Date: Mon Nov 23 21:10:27 2015 -0500
drmgr: Remove extraneous "d" in buffer
Remove an erroneous character left in a print statement used
to update the drconf property.
Signed-off-by: Nathan Fontenot <[email protected]>
commit f4006893d84c85bbf5b86919c28ba56047001204
Author: Nathan Fontenot <[email protected]>
Date: Mon Nov 23 21:09:47 2015 -0500
drmgr: Correct return code from set_mem_scn_state()
The set_mem_scn_state() routine incorrectly returns the number of chars
written in the case of success instead of returning 0. This results in the
caller assuming a failure occurred when setting the memroy section state
and fails the memory online/offline operation.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 4f515ea179cb36f26adb53c93b79f834e32c2abe
Author: Nathan Fontenot <[email protected]>
Date: Mon Nov 23 21:08:54 2015 -0500
drmgr: Correct LMB counting when discovering LMBs
Recent updates to how drmgr counted the number of LMBs found did
not save the count value correctly and in the case of LMBs found
in the ibm,dynamic-reconfiguration-memory property only counted
LMBs that were present. This caused havoc when trying to shuffle
the LMBs.
Save the LMB count in the lmb_list_head struct so we have it across
function calls. Also update the shuffle_lmbs to just take a pointer to
the lmb_list_head and make changes locally in the routine.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 9a1957588b040db0dddfa284dbb96a817e699792
Author: Cédric Le Goater <[email protected]>
Date: Mon Nov 23 21:07:17 2015 -0500
update_flash_nv: improve check_ipmitool
This patch adds a quick test in check_ipmitool to make sure the
BMC is alive
Signed-off-by: Cédric Le Goater <[email protected]>
commit 4e4e5f9f8d16a2ad196d1fd5388de23aa2e1fdbc
Author: Cédric Le Goater <[email protected]>
Date: Mon Nov 23 21:06:52 2015 -0500
update_flash_nv: fix firmware update sequence for powernv
This patch modifies the way the firmware update is performed from
the host. It adds a cold reset of the BMC before and after the
update.
Signed-off-by: Cédric Le Goater <[email protected]>
commit 1f25105c1c7f1384be4aef03f2aa6d5bd065eb11
Author: Cédric Le Goater <[email protected]>
Date: Mon Nov 23 21:06:22 2015 -0500
update_flash_nv: force the use of the ipmitool usb backend
Signed-off-by: Cédric Le Goater <[email protected]>
commit b0e5ba4f55dcf1a5d013eddbb95b660c65504b3c
Author: Nishanth Aravamudan <[email protected]>
Date: Mon Nov 23 21:04:45 2015 -0500
ppc64_cpu: output to user if the requested number of cores are not brought o
Now that we check the return code from set_one_core, we should ensure
that the requested number of cores in --cores-on is achieved, or return
-1 intead. Also add a slightly verbose message in that case.
Signed-off-by: Nishanth Aravamudan <[email protected]>
commit 1a1bb7167a3946712a5b59b5566bac6ced46cdc9
Author: Nishanth Aravamudan <[email protected]>
Date: Mon Nov 23 21:03:37 2015 -0500
ppc64_cpu: use rc instead of boolean flag
We can overload the rc variable, reducing the number of local variables
in do_online_cores.
Signed-off-by: Nishanth Aravamudan <[email protected]>
commit 37eeba5583d48558f2ca1de6096df83494005e6f
Author: Nishanth Aravamudan <[email protected]>
Date: Mon Nov 23 21:00:14 2015 -0500
ppc64_cpu: check return code from set_one_core
In both --cores-on and --online-cores, the return code from the helper
function set_one_core is not checked. This can lead to ppc64_cpu
returning 0 even though the command technically failed to do what was
requested. After this patch, --cores-on still doesn't return a proper
error code (fixing in a follow-on).
Signed-off-by: Nishanth Aravamudan <[email protected]>
commit 9711ee00b604a39d47dfced7f0c49cf40600131f
Author: Nishanth Aravamudan <[email protected]>
Date: Tue Nov 17 16:24:37 2015 -0500
ppc64_cpu: add --{on,off}line-cores to {on,off}line specific cores
We currently have support for a mechanism to ensure an exact number of
cores (or all cores after a recent patch submission) are online.
However, there is no control over which cores are selected. Add two new
options to ppc64_cpu, --online-cores and --offline-cores to support
specifying which cores to bring online or offline, respectively. Both
options take either no parameters, in which case they output a
comma-separated list of cores that are online/offline, or a
comma-separated list of cores, in which case the command sets those
cores' states to online/offline.
Signed-off-by: Nishanth Aravamudan <[email protected]>
commit 2239dd005e00d63c6e68fe962928b5f0b08ef6cb
Author: Nishanth Aravamudan <[email protected]>
Date: Tue Nov 17 09:33:55 2015 -0500
ppc64_cpu: rename do_cores_online to do_cores_on
This matches the other function names more closely.
Signed-off-by: Nishanth Aravamudan <[email protected]>
commit bb8472f0658565e5188150a141fa8856b55000ca
Author: Nishanth Aravamudan <[email protected]>
Date: Tue Nov 17 09:31:57 2015 -0500
ppc64_cpu: add all parameter to --cores-on to online all cores
Rather than finding out how many cores are in a system, and then passing
that value to --cores-on, it can be handy to have a shortcut to just
online all cores.
Signed-off-by: Nishanth Aravamudan <[email protected]>
commit 17cd4bbf7c20d8096523c765c1157e4a58d31363
Author: Nishanth Aravamudan <[email protected]>
Date: Tue Nov 17 09:29:06 2015 -0500
ppc64_cpu: handle errors from strtol in --cores-on parsing
Currently, on a 24-core system, passing certain values to `ppc64_cpu
--cores-on` leads to some surprising results:
ppc64_cpu --cores-on=all
ppc64_cpu --cores-on=adfd
offlines all but one core
This is because we are not using the endptr parameter of strtol to
determine if any of the string is consumed (and if none of the string is
consumed, strtol still returns a valid long value, namely 0).
ppc64_cpu --cores-on=12df
onlines 12 cores
This is because we are not using the endptr parameter to strtol to
determine if the entire string is consumed (checking for trailing
characters).
Add both these checks.
After this patch:
ppc64_cpu --cores-on=all
Invalid number of cores to online: all
ppc64_cpu --cores-on=adfd
Invalid number of cores to online: adfd
ppc64_cpu --cores-on=12fd
Invalid number of cores to online: 12fd
Signed-off-by: Nishanth Aravamudan <[email protected]>
commit 475919d4294819e5f890f000ccadf5b13280a0a9
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 16:50:11 2015 -0500
powerpc-utils.spec: Fix typo in spec-file
In line:
%{__rm} -rf $RPM_BULD_ROOT
The directory should be RPM_BUILD_ROOT not RPM_BULD_ROOT
Signed-off-by: Chandni Verma <[email protected]>
commit b1d909378cf8a9502c7207f4f51a2cf3931d5263
Author: Michael Bringmann <[email protected]>
Date: Mon Nov 16 16:48:30 2015 -0500
errinjct/rtas_debug: Update RPM packaging specs
This patch updates the powerpc-utils.spec.in file to install the binaries
associated with errinjct and rtas_dbg.
Signed-off-by: Michael Bringmann <[email protected]>
commit 03704771a36c025eb8636a90f67eaa77acd5880d
Author: Nathan Fontenot <[email protected]>
Date: Mon Nov 16 16:40:47 2015 -0500
lsslot/drmgr: Performance enhancement for parsing LMBs
Signed-off-by: Nathan Fontenot <[email protected]>
commit 268116acde0d5f98efa150044b68d977d578ccb4
Author: Vasant Hegde <[email protected]>
Date: Mon Nov 16 16:39:15 2015 -0500
errinjct: Add format specificer
We hit below build warning with "-Werror=format-security" compilation option
CC src/errinjct/icache.o
src/errinjct/errinjct.c: In function 'perr':
src/errinjct/errinjct.c:240:18: error: format not a string literal and no f
fprintf(stderr, buf);
^
Signed-off-by: Vasant Hegde <[email protected]>
commit c2091227bdf40192a37456445a6dedf3f3da8cda
Author: Nathan Fontenot <[email protected]>
Date: Mon Nov 16 16:27:08 2015 -0500
drmgr: Do not allow DLPAR of display adapters
The DLPAR of display adapters has never been supported but that support
has not ever been enforced in drmgr. Recent tests show that trying to DLPAR
remove a display adapter causes the drmngr command to appear hung as it
waits for display adapters to power down.
Add the ability to check for a drc-type of 'display' when trying to add
or remove a pci or slot, and verify that none of the children under a
PHB are display adapters when trying to add or remove a PHB.
Signed-off-by: Nathan Fontenot <[email protected]>
commit aef0c5daa20f38b66e5fa0255ecf5a53ba202138
Author: Nathan Fontenot <[email protected]>
Date: Mon Nov 16 16:26:01 2015 -0500
drmgr: Move check for non-hotplug children to common routine
In more than one place we check to see if a PHB has any children that
are not hotplug capable. Move this code to common routine.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 2d8ad5ef33948f07e3022c601ee99cd8efc85a76
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 16:22:19 2015 -0500
activate_firmware: Have man page reflect the changes made in this branch
-Edited description
-added Option section
-Added 2 new return codes 7 and 8
Signed-off-by: Chandni Verma <[email protected]>
commit 11041ab9e8f0e75b58d2c1a593c9c410d7a82f00
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 16:21:02 2015 -0500
activate_fw: Return code 8, to report a parameter error when activating firm
This is a new return code mapped from rtas return code -3 which is returned
case of parameter error, when the utility is used without options.
Signed-off-by: Chandni Verma <[email protected]>
commit d1217de2906f22dbeed54f52c683f28ffcfe90c9
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 16:19:56 2015 -0500
activate_fw: get update access key expiry date, set update access key
This patch provides two feature extensions:
1. activate_firmware -e
(with only -e, fetches the update access key expiry date)
2. activate_firmware -e /path/to/keyfile
(with an argument to -e applies the provided update access key-file to
extend the update access key expiry date)
These are required to provide an interface to check validity of and
update the Update Access Key. ESA will be one of the users of this tool.
Signed-off-by: Chandni Verma <[email protected]>
commit 097c16987a65aceb0be6d66befaa0104b518abbd
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 16:18:09 2015 -0500
activate_fw.c: Make use of errx() to print error messages to stderr and exit
This is a more compact way to do it compared to using fprintf and explicitly
exiting in main()
Signed-off-by: Chandni Verma <[email protected]>
commit c2dc2191bb5963b09e781b78cbf2a152520c8e87
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 16:17:21 2015 -0500
activate_fw.c: Factor out activate_firmware() from main()
This is done to reserve main solely for option processing and to
abstract out rtas calling function.
Signed-off-by: Chandni Verma <[email protected]>
commit 72bc893a5f4b59d0e7742726e85f3cffab65ebd3
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 16:14:46 2015 -0500
activate_fw: fix typo
The default case in error handler should return code 6, not 4.
Signed-off-by: Chandni Verma <[email protected]>
commit 782445384c165ea28f00c9cb233e41bdeef7a962
Author: Chandni Verma <[email protected]>
Date: Mon Nov 16 15:53:42 2015 -0500
activate_fw: Coding style fixes
This patch fixes trailing white spaces and indentation issues
and in general makes to code confirm to linux's checkpatch.pl
Signed-off-by: Chandni Verma <[email protected]>
commit ad93027170afe3b7bc760fed0ab3e078390ba088
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:58:44 2015 -0400
serv_config: Compile warning cleanups
Correct several compile warnings.
Remove unchecked return code from execv().
Remove unused variables.
Correct de-reference of type punned pointers.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 8ad7081b5f1d98593c8192d4d46c10050e5b8d88
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:57:34 2015 -0400
rtas_ibm_get_vpd: Compile warning cleanups
Clean up compile warning by removing the unused lflag variable.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 28aeacd59e0e35753bae243cf63150f6ecc2a10b
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:56:32 2015 -0400
rtas_dbg: Compile warning cleanups
Correct compile errors to check the return value from a fread() call and
add an appropriate error message, and ensuring we do not use an
uninitialized 'rc' variable.
Signed-off-by: Nathan Fontenot <[email protected]>
commit dfab2e6f11a11e25da342b703bd054aaf906d818
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:55:33 2015 -0400
ppc64_cpu: Compile warning cleanups
Correct compile warning for dereference of type punned pointer.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 92fd02382fbec464562e2a84841391f09cf1e2ea
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:54:34 2015 -0400
nvram: Compile warning cleanups
Correct compile warning by removing the unused variable memctrl_data.
Signed-off-by: Nathan Fontenot <[email protected]>
commit f069a159755b70bf4596b2bcce5b3fb4f8c3831f
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:53:35 2015 -0400
lparstat: Compile warning cleanups
Clean up compile warnings by adding checks for the return codes from
fgets() calls and adding appropriate error messages.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 2cc2e6590a43a367ee6ca6474bc98cc0a7245caf
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:51:59 2015 -0400
drmgr: Compile warning cleanups
Fix multiple warnings generated when compiling drmgr code. These include
not checking return codes of fread() and write() calls where a check is
added and appropriate error messages.
Updating print formats to use the appropriate type of value being printed.
Correcting the use of rc values to ensure the rc variable is set.
Signed-off-by: Nathan Fontenot <[email protected]>
commit 0e8d1534f5bf57798b74584b6f2b42bad57ddf89
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:49:57 2015 -0400
drmgr: Validate the status of a CPU before adding or removing it
When asked to perform a CPU DLPAR operation we should verify the current
status of the CPU before performing the operation. Failure to verify the
status has caused the kernel to oops in cases where we try to add a CPU
that is already owned, namely in a kvm guest the following is seen.
Signed-off-by: Nathan Fontenot <[email protected]>
commit dabc0264a9f3b64226da63421378ed02f2f1b201
Author: Nathan Fontenot <[email protected]>
Date: Tue Oct 27 16:48:25 2015 -0400