"make install-strip" chokes on libexec/less-osc8-file

[Keith-S-Thompson]

I built less v699 from source on Ubuntu 24.04.4.

The make install-strip step fails with:

strip: …/less-699-pcre2/libexec/less-osc8-file: file format not recognized
/usr/bin/install: strip process terminated abnormally

In release v697, the libexec directory contains only lessecho, a binary executable.
In release v699, it also contains less-osc8-file and less-osc8-man, which are (unstrippable) shell scripts.
(I think this affects v698 as well.)

Workaround: Use make install rather than make install-strip and then run strip manually.

[Keith-S-Thompson]

Suggested patch:

diff --git Makefile.in Makefile.in
index d67465a..f7f391d 100644
--- Makefile.in
+++ Makefile.in
@@ -85,8 +85,8 @@ install: all ${srcdir}/less.nro ${srcdir}/lesskey.nro ${srcdir}/lessecho.nro ins
        ${INSTALL_PROGRAM} less$(EXEEXT) ${DESTDIR}${bindir}/${binprefix}less$(EXEEXT)
        ${INSTALL_PROGRAM} lesskey$(EXEEXT) ${DESTDIR}${bindir}/${binprefix}lesskey$(EXEEXT)
        ${INSTALL_PROGRAM} lessecho$(EXEEXT) ${DESTDIR}${libexecdir}/${binprefix}lessecho$(EXEEXT)
-       ${INSTALL_PROGRAM} ${srcdir}/less-osc8-file.bash ${DESTDIR}${libexecdir}/${binprefix}less-osc8-file
-       ${INSTALL_PROGRAM} ${srcdir}/less-osc8-man.bash ${DESTDIR}${libexecdir}/${binprefix}less-osc8-man
+       ${INSTALL_DATA} ${srcdir}/less-osc8-file.bash ${DESTDIR}${libexecdir}/${binprefix}less-osc8-file
+       ${INSTALL_DATA} ${srcdir}/less-osc8-man.bash ${DESTDIR}${libexecdir}/${binprefix}less-osc8-man
        ${INSTALL_DATA} ${srcdir}/less.nro ${DESTDIR}${mandir}/man${manext}/${manprefix}less.${manext}
        ${INSTALL_DATA} ${srcdir}/lesskey.nro ${DESTDIR}${mandir}/man${manext}/${manprefix}lesskey.${manext}
        ${INSTALL_DATA} ${srcdir}/lessecho.nro ${DESTDIR}${mandir}/man${manext}/${manprefix}lessecho.${manext}

[gwsw]

Thanks, fixed in 953bc9e.

[gwsw]

It turns out that it's not correct to use INSTALL_DATA to install a shell script, since that removes the exec bit from the file mode. Fixed in 56de795.