Skip to content

Commit 334324d

Browse files
committed
remove redundant detail from custom event
1 parent 2964169 commit 334324d

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

dotcom-rendering/src/components/StickyBottomBanner.importable.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -406,15 +406,12 @@ export const StickyBottomBanner = ({
406406
isInAuxiaControlGroup,
407407
]);
408408

409-
//Dispatches 'banner:none' event after pickMessage completes with no banner selected.
410-
//hasPickMessageCompleted distinguishes between initial state (not picked yet) and final state (picked nothing).
409+
// Dispatches 'banner:none' event for mobile sticky ad integration (see @guardian/commercial-dev).
410+
// Ensures ads only insert when no banner will be shown.
411+
// hasPickMessageCompleted distinguishes between initial state (not picked yet) and final state (picked nothing).
411412
useEffect(() => {
412413
if (hasPickMessageCompleted && SelectedBanner == null) {
413-
document.dispatchEvent(
414-
new CustomEvent('banner:none', {
415-
detail: { readerRevenue: false },
416-
}),
417-
);
414+
document.dispatchEvent(new CustomEvent('banner:none'));
418415
}
419416
}, [SelectedBanner, hasPickMessageCompleted]);
420417
if (SelectedBanner) {

0 commit comments

Comments
 (0)