Fix Vehicle's break location is ignored #439#440
Closed
reinterpretcat wants to merge 1 commit intographhopper:masterfrom
reinterpretcat:master
Closed
Fix Vehicle's break location is ignored #439#440reinterpretcat wants to merge 1 commit intographhopper:masterfrom reinterpretcat:master
reinterpretcat wants to merge 1 commit intographhopper:masterfrom
reinterpretcat:master
Conversation
annepatricio
approved these changes
Nov 20, 2024
annepatricio
left a comment
annepatricio
left a comment
There was a problem hiding this comment.
Thanks for this fix @reinterpretcat! It worked perfectly for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original BreakInsertionCalculator ignores the fact that break has fixed location. To fix that, seems we can reuse insertion logic from ServiceInsertionCalculator.