fixup! feat: add config migration

Author: jmattheis

config/migrate/migrate.go

@@ -1,6 +1,7 @@
 package migrate
 
 import (
+	"encoding/csv"
 	"encoding/json"
 	"errors"
 	"fmt"
@@ -111,7 +112,7 @@ func buildEnv(c oldConfig) map[string]string {
 	}
 	list := func(key string, value []string) {
 		if value != nil {
-			out[key] = strings.Join(value, ",")
+			out[key] = marshalList(value)
 		}
 	}
 	headers := func(key string, value map[string]string) {
@@ -171,3 +172,14 @@ func marshalMap(m map[string]string) string {
 	}
 	return string(data)
 }
+
+func marshalList(values []string) string {
+	var sb strings.Builder
+	writer := csv.NewWriter(&sb)
+	writer.UseCRLF = false
+	if err := writer.Write(values); err != nil {
+		return ""
+	}
+	writer.Flush()
+	return strings.TrimRight(sb.String(), "\n")
+}

config/migrate/migrate_test.go

@@ -142,6 +142,20 @@ GOTIFY_SERVER_PORT=80
 GOTIFY_SERVER_SSL_REDIRECTTOHTTPS="true"`, runMigrate(t, yaml))
 }
 
+func TestMigrateConfigEscapesListEntries(t *testing.T) {
+	yaml := `server:
+  cors:
+    alloworigins:
+      - a,b
+      - 'say "hi"'
+      - c
+`
+	// The CSV-encoded list contains commas and quotes, which godotenv then
+	// double-quotes and escapes.
+	assert.Contains(t, runMigrate(t, yaml),
+		`GOTIFY_SERVER_CORS_ALLOWORIGINS="\"a,b\",\"say \"\"hi\"\"\",c"`)
+}
+
 func TestMigrateConfigErrors(t *testing.T) {
 	_, err := Config("")
 	assert.ErrorContains(t, err, "requires one argument", "no path -> usage error")