Skip to content

Add annotation settings for frontend Service helm #1441

Description

@SpringMT

Is your feature request related to a problem? Please describe.
I try to use open-match with AWS EKS.
In AWS EKS, aws-load-balancer-controller is needed using AWS LB(ALB or NLB) for k8s Service.
https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.3/guide/service/annotations/
Usingaws-load-balancer-controller, need some annotations for Service.

But, no annotaion options for frontend Service.
https://github.com/googleforgames/open-match/blob/main/install/helm/open-match/templates/frontend.yaml#L21 .

Describe the solution you'd like
Add frontend.service.annotations settings for Helm.
And apply frontend.service.annotations to frontend.yaml like below.

--- a/install/helm/open-match/templates/frontend.yaml
+++ b/install/helm/open-match/templates/frontend.yaml
@@ -18,7 +18,13 @@ apiVersion: v1
 metadata:
   name: {{ include "openmatch.frontend.hostName" . }}
   namespace: {{ .Release.Namespace }}
-  annotations: {{- include "openmatch.chartmeta" . | nindent 4 }}
+  annotations:
+    {{- include "openmatch.chartmeta" . | nindent 4 }}
+    {{- if .Values.frontend.service.annotations }}
+    {{- range $key, $value := .Values.frontend.service.annotations }}
+    {{ $key }}: {{ $value | quote }}
+    {{- end }}
+    {{- end }}
   labels:
     app: {{ template "openmatch.name" . }}
     component: frontend

Describe alternatives you've considered

Additional context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions