Skip to content

Commit 1548dce

Browse files
committed
feat(gax): implement actionable errors logging in ApiTracer framework
1 parent 555dd7d commit 1548dce

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

gax-java/gax/src/main/java/com/google/api/gax/rpc/ClientContext.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -281,13 +281,11 @@ public static ClientContext create(StubSettings settings) throws IOException {
281281
if (apiTracerFactory instanceof SpanTracerFactory) {
282282
apiTracerFactory = apiTracerFactory.withContext(apiTracerContext);
283283
}
284-
if (com.google.api.gax.logging.LoggingUtils.isLoggingV2Enabled()) {
285-
com.google.api.gax.tracing.ApiTracerFactory loggingTracerFactory =
286-
new com.google.api.gax.tracing.LoggingTracerFactory().withContext(apiTracerContext);
287-
apiTracerFactory =
288-
new com.google.api.gax.tracing.CompositeTracerFactory(
289-
apiTracerFactory, loggingTracerFactory);
290-
}
284+
com.google.api.gax.tracing.ApiTracerFactory loggingTracerFactory =
285+
new com.google.api.gax.tracing.LoggingTracerFactory().withContext(apiTracerContext);
286+
apiTracerFactory =
287+
new com.google.api.gax.tracing.CompositeTracerFactory(
288+
apiTracerFactory, loggingTracerFactory);
291289

292290
return newBuilder()
293291
.setBackgroundResources(backgroundResources.build())

gax-java/gax/src/main/java/com/google/api/gax/tracing/LoggingTracer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,6 @@ private void recordActionableError(Throwable error) {
118118

119119
String message = error.getMessage() != null ? error.getMessage() : error.getClass().getName();
120120
LoggingUtils.logActionableError(
121-
logContext, LOGGER_PROVIDER, org.slf4j.event.Level.INFO, message);
121+
logContext, LOGGER_PROVIDER, org.slf4j.event.Level.DEBUG, message);
122122
}
123123
}

0 commit comments

Comments
 (0)