nodejs: migrate+generate produces diffs for google-cloud-secretmanager

[julieqiu]

Running migrate followed by librarian generate on google-cloud-secretmanager produces these diffs:

Expected

  D  packages/google-cloud-secretmanager/.OwlBot.yaml (migrate removes OwlBot config)

Needs google-cloud-node cleanup

  M  packages/google-cloud-secretmanager/samples/generated/v1/snippet_metadata_google.cloud.secretmanager.v1.json (version 0.1.0 → 6.1.1)
  M  packages/google-cloud-secretmanager/samples/generated/v1beta2/snippet_metadata_google.cloud.secretmanager.v1beta2.json (version 0.1.0 →
  6.1.1)
  D  packages/google-cloud-secretmanager/samples/generated/v1/snippet_metadata.google.cloud.secretmanager.v1.json (old dot-pattern superseded
   by underscore-pattern)
  M  packages/google-cloud-secretmanager/src/index.ts (copyright year 2025 → 2026)

These diffs exist because google-cloud-node has stale data that will be corrected on the first generate run.

• The snippet metadata files have a placeholder version (0.1.0) that gets updated to the real library version (6.1.1).
• The dot-pattern snippet metadata file is a duplicate that existed alongside the underscore-pattern file and gets cleaned up.
• The copyright year in src/index.ts was behind by one year.

We should make these changes upstream in google-cloud-node so that when we migrate we do not get these diffs.

Needs investigation: proto changes

  D  packages/google-cloud-secretmanager/protos/google/cloud/secrets/v1beta1/resources.proto
  D  packages/google-cloud-secretmanager/protos/google/cloud/secrets/v1beta1/service.proto
  M  packages/google-cloud-secretmanager/protos/protos.d.ts (+522 lines)
  M  packages/google-cloud-secretmanager/protos/protos.js (+1823 lines)
  M  packages/google-cloud-secretmanager/protos/protos.json (+228 lines)

The v1beta1 protos under google.cloud.secrets (not google.cloud.secretmanager) are deleted because they are not in any API config. See #4820 for broader context on proto diff investigation.

Needs investigation: code removed

  M  packages/google-cloud-secretmanager/src/v1/secret_manager_service_client.ts (-118 lines)
  M  packages/google-cloud-secretmanager/src/v1beta2/secret_manager_service_client.ts (-26 lines)
  M  packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1.ts (-30 lines)
  M  packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1beta2.ts (-30 lines)

The v1 and v1beta2 clients and their tests seem to have lost hand-added code from googleapis/google-cloud-node@5e14553 and googleapis/google-cloud-node@2e5fe96. Investigation is needed to figure out whether this code is needed, and if so, how to preserve it.

Steps to reproduce

  cd $LIBRARIAN_REPO
  go install ./cmd/librarian && go install ./tool/cmd/migrate
  cd $GOOGLE_CLOUD_NODE_REPO
  git fetch upstream && git reset --hard upstream/main
  migrate .
  librarian generate google-cloud-secretmanager
  git diff --stat

Tool versions

Tool	Version
google-cloud-node	1b44bd1872
gapic-generator-typescript	4.11.12
gapic-tools	1.0.3 (bundled with gapic-generator)
gapic-node-processing	0.1.7