all: fix linter errors

1. govet catched %q misuse
2. staticcheck catched deprecated spanner.SessionPoolConfig

Author: tarasmadan

dashboard/app/aidb/crud.go

@@ -243,12 +243,7 @@ func dbClient(ctx context.Context) (*spanner.Client, error) {
 	path := fmt.Sprintf("projects/%v/instances/%v/databases/%v",
 		appID, Instance, Database)
 	// We use background context for the client, so that it survives the request.
-	client, err := spanner.NewClientWithConfig(context.Background(), path, spanner.ClientConfig{
-		SessionPoolConfig: spanner.SessionPoolConfig{
-			MinOpened: 1,
-			MaxOpened: 20,
-		},
-	})
+	client, err := spanner.NewClientWithConfig(context.Background(), path, spanner.ClientConfig{})
 	if err != nil {
 		return nil, err
 	}

dashboard/app/email_test.go

@@ -950,7 +950,7 @@ func TestSubjectTitleParser(t *testing.T) {
 		} else if title != test.outTitle {
 			t.Fatalf("subj: %q, expected title=%q, got %q", test.inSubject, test.outTitle, title)
 		} else if seq != test.outSeq {
-			t.Fatalf("subj: %q, expected seq=%q, got %q", test.inSubject, test.outSeq, seq)
+			t.Fatalf("subj: %q, expected seq=%d, got %d", test.inSubject, test.outSeq, seq)
 		}
 	}
 }

pkg/ast/format.go

@@ -274,7 +274,7 @@ func fmtExpressionRec(sb *strings.Builder, t *Type, parentPrio int) {
 	case OperatorOr:
 		sb.WriteString("||")
 	default:
-		panic(fmt.Sprintf("unknown operator %q", be.Operator))
+		panic(fmt.Sprintf("unknown operator %v", be.Operator))
 	}
 	sb.WriteByte(' ')
 	fmtExpressionRec(sb, be.Right, myPrio)
@@ -289,7 +289,7 @@ func operatorPrio(op Operator) int {
 			return info.prio
 		}
 	}
-	panic(fmt.Sprintf("unknown operator %q", op))
+	panic(fmt.Sprintf("unknown operator %v", op))
 }
 
 func comma(i int, or string) string {

pkg/ast/scanner.go

@@ -82,7 +82,7 @@ func init() {
 		if tok == tokIllegal {
 			continue
 		}
-		tok2str[tok] = fmt.Sprintf("%q", ch)
+		tok2str[tok] = fmt.Sprintf("%q", rune(ch))
 	}
 }
 

pkg/compiler/gen.go

@@ -144,7 +144,7 @@ func (comp *compiler) genSyscall(n *ast.Call, argSizes []uint64) *prog.Syscall {
 		case flagAttr:
 			fld.SetBool(val != 0)
 		default:
-			panic(fmt.Sprintf("unexpected attrDesc type: %q", desc.Type))
+			panic(fmt.Sprintf("unexpected attrDesc type: %v", desc.Type))
 		}
 	}
 	for desc, val := range stringAttrs {
@@ -153,7 +153,7 @@ func (comp *compiler) genSyscall(n *ast.Call, argSizes []uint64) *prog.Syscall {
 		case stringAttr:
 			fld.SetString(val)
 		default:
-			panic(fmt.Sprintf("unexpected attrDesc type: %q", desc.Type))
+			panic(fmt.Sprintf("unexpected attrDesc type: %v", desc.Type))
 		}
 	}
 	fields, _ := comp.genFieldArray(n.Args, argSizes)

pkg/cover/backend/gvisor.go

@@ -97,10 +97,10 @@ func gvisorSymbolize(bin, srcDir string) ([]*Frame, error) {
 func gvisorParseLine(s *bufio.Scanner) (*Frame, error) {
 	pc, err := strconv.ParseUint(s.Text(), 0, 64)
 	if err != nil {
-		return nil, fmt.Errorf("read pc %q, but no line info", pc)
+		return nil, fmt.Errorf("read pc %x, but no line info", pc)
 	}
 	if !s.Scan() {
-		return nil, fmt.Errorf("read pc %q, but no line info", pc)
+		return nil, fmt.Errorf("read pc %x, but no line info", pc)
 	}
 	match := gvisorLineRe.FindStringSubmatch(s.Text())
 	if match == nil {

pkg/instance/instance_test.go

@@ -83,7 +83,7 @@ func TestExecprogCmd(t *testing.T) {
 		t.Errorf("bad sandbox: %q, want: %q", *flagSandbox, "namespace")
 	}
 	if *flagSandboxArg != 3 {
-		t.Errorf("bad sandbox_arg: %q, want: %q", *flagSandboxArg, 3)
+		t.Errorf("bad sandbox_arg: %v, want: %v", *flagSandboxArg, 3)
 	}
 	if *flagSignal {
 		t.Errorf("bad signal: %v, want: %v", *flagSignal, false)

prog/expr.go

@@ -36,7 +36,7 @@ func (bo BinaryExpression) Evaluate(finder ArgFinder) (uint64, bool) {
 		}
 		return 0, true
 	}
-	panic(fmt.Sprintf("unknown operator %q", bo.Operator))
+	panic(fmt.Sprintf("unknown operator %v", bo.Operator))
 }
 
 func (v *Value) Evaluate(finder ArgFinder) (uint64, bool) {