Skip to content

Commit a15267f

Browse files
chore: fix unit test
1 parent d42a74d commit a15267f

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

tests/unittests/cli/test_cli_generate_agent_card.py

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,11 @@ def mock_agent_loader():
3636

3737
@pytest.fixture
3838
def mock_agent_card_builder():
39+
mock_module = MagicMock()
3940
with patch.dict(
40-
"sys.modules", {"google.adk.a2a.utils.agent_card_builder": MagicMock()}
41+
"sys.modules", {"google.adk.a2a.utils.agent_card_builder": mock_module}
4142
):
42-
with patch(
43-
"google.adk.a2a.utils.agent_card_builder.AgentCardBuilder"
44-
) as mock:
45-
yield mock
43+
yield mock_module.AgentCardBuilder
4644

4745

4846
def test_generate_agent_card_missing_a2a(runner):
@@ -78,11 +76,12 @@ def test_generate_agent_card_missing_a2a(runner):
7876
pass
7977

8078

81-
@patch("google.adk.cli.utils.agent_loader.AgentLoader")
82-
@patch("google.adk.a2a.utils.agent_card_builder.AgentCardBuilder")
79+
@patch("google.adk.cli.cli_generate_agent_card.AgentLoader")
8380
def test_generate_agent_card_success_no_file(
84-
mock_builder_cls, mock_loader_cls, runner
81+
mock_loader_cls, mock_agent_card_builder, runner
8582
):
83+
# Setup mocks
84+
mock_builder_cls = mock_agent_card_builder
8685
# Setup mocks
8786
mock_loader = mock_loader_cls.return_value
8887
mock_loader.list_agents.return_value = ["agent1"]
@@ -115,11 +114,12 @@ def test_generate_agent_card_success_no_file(
115114
mock_builder.build.assert_called_once()
116115

117116

118-
@patch("google.adk.cli.utils.agent_loader.AgentLoader")
119-
@patch("google.adk.a2a.utils.agent_card_builder.AgentCardBuilder")
117+
@patch("google.adk.cli.cli_generate_agent_card.AgentLoader")
120118
def test_generate_agent_card_success_create_file(
121-
mock_builder_cls, mock_loader_cls, runner, tmp_path
119+
mock_loader_cls, mock_agent_card_builder, runner, tmp_path
122120
):
121+
# Setup mocks
122+
mock_builder_cls = mock_agent_card_builder
123123
# Setup mocks
124124
cwd = tmp_path / "project"
125125
cwd.mkdir()
@@ -151,11 +151,12 @@ def test_generate_agent_card_success_create_file(
151151
assert content["name"] == "agent1"
152152

153153

154-
@patch("google.adk.cli.utils.agent_loader.AgentLoader")
155-
@patch("google.adk.a2a.utils.agent_card_builder.AgentCardBuilder")
154+
@patch("google.adk.cli.cli_generate_agent_card.AgentLoader")
156155
def test_generate_agent_card_agent_error(
157-
mock_builder_cls, mock_loader_cls, runner
156+
mock_loader_cls, mock_agent_card_builder, runner
158157
):
158+
# Setup mocks
159+
mock_builder_cls = mock_agent_card_builder
159160
# Setup mocks
160161
mock_loader = mock_loader_cls.return_value
161162
mock_loader.list_agents.return_value = ["agent1", "agent2"]

0 commit comments

Comments
 (0)