Skip to content

Commit a0fad41

Browse files
test: improvement
1 parent 30ee45d commit a0fad41

File tree

1 file changed

+14
-18
lines changed

1 file changed

+14
-18
lines changed

tests/unittests/cli/test_cli_generate_agent_card.py

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -116,18 +116,11 @@ def test_generate_agent_card_success_no_file(
116116

117117
@patch("google.adk.cli.cli_generate_agent_card.AgentLoader")
118118
def test_generate_agent_card_success_create_file(
119-
mock_loader_cls, mock_agent_card_builder, runner, tmp_path
119+
mock_loader_cls, mock_agent_card_builder, runner
120120
):
121121
# Setup mocks
122122
mock_builder_cls = mock_agent_card_builder
123-
# Setup mocks
124-
cwd = tmp_path / "project"
125-
cwd.mkdir()
126-
os.chdir(cwd)
127-
128-
agent_dir = cwd / "agent1"
129-
agent_dir.mkdir()
130-
123+
131124
mock_loader = mock_loader_cls.return_value
132125
mock_loader.list_agents.return_value = ["agent1"]
133126
mock_agent = MagicMock()
@@ -138,17 +131,20 @@ def test_generate_agent_card_success_create_file(
138131
mock_card.model_dump.return_value = {"name": "agent1", "description": "test"}
139132
mock_builder.build = AsyncMock(return_value=mock_card)
140133

141-
# Run command
142-
result = runner.invoke(generate_agent_card, ["--create-file"])
134+
with runner.isolated_filesystem():
135+
os.mkdir("agent1")
143136

144-
assert result.exit_code == 0
137+
# Run command
138+
result = runner.invoke(generate_agent_card, ["--create-file"])
139+
140+
assert result.exit_code == 0
145141

146-
# Verify file creation
147-
agent_json = agent_dir / "agent.json"
148-
assert agent_json.exists()
149-
with open(agent_json, "r") as f:
150-
content = json.load(f)
151-
assert content["name"] == "agent1"
142+
# Verify file creation
143+
agent_json = os.path.join("agent1", "agent.json")
144+
assert os.path.exists(agent_json)
145+
with open(agent_json, "r") as f:
146+
content = json.load(f)
147+
assert content["name"] == "agent1"
152148

153149

154150
@patch("google.adk.cli.cli_generate_agent_card.AgentLoader")

0 commit comments

Comments
 (0)