Skip to content

Fix unwanted text‑node merging on libxml2 2.12+ by manually updating doc pointers #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfm merged 1 commit into from
Jan 22, 2026
+1,332 −24
Merged

Fix unwanted text‑node merging on libxml2 2.12+ by manually updating doc pointers #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions Source/NSXMLElement.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,22 +163,42 @@ - (NSArray*) elementsForName: (NSString*)name
NSMutableArray *results = [NSMutableArray arrayWithCapacity: 10];
xmlNodePtr cur = NULL;
const xmlChar *xmlName = XMLSTRING(name);

xmlNsPtr defaultNS = NULL;

// Find the default namespace (empty or NULL prefix) of this parent element
xmlNsPtr ns;
for (ns = internal->node.node->nsDef; ns != NULL; ns = ns->next)
{
if (ns->prefix == NULL || xmlStrcmp(ns->prefix, (const xmlChar*)"") == 0)
{
defaultNS = ns;
break;
}
}

for (cur = internal->node.node->children; cur != NULL; cur = cur->next)
{
if (cur->type == XML_ELEMENT_NODE)
{
// no namespace or default namespace
if ((xmlStrcmp(xmlName, cur->name) == 0) &&
((cur->ns == NULL) || (cur->ns->prefix == NULL) ||
(xmlStrcmp(cur->ns->prefix, (const xmlChar*)"") == 0)))
if (xmlStrcmp(xmlName, cur->name) == 0)
{
NSXMLNode *theNode = [NSXMLNode _objectForNode: cur];
[results addObject: theNode];
// Match elements with no namespace
if (cur->ns == NULL)
{
NSXMLNode *theNode = [NSXMLNode _objectForNode: cur];
[results addObject: theNode];
}
// Match elements in the default namespace if one exists
else if (defaultNS != NULL && cur->ns->href != NULL &&
xmlStrcmp(cur->ns->href, defaultNS->href) == 0)
{
NSXMLNode *theNode = [NSXMLNode _objectForNode: cur];
[results addObject: theNode];
}
}
}
}

return results;
}
}
Expand Down
Loading