enhance reservation log messages

Author: cconard96

front/reservation.form.php

@@ -95,16 +95,22 @@
     $_POST['begin']   = $_POST['resa']["begin"];
     $_POST['end']     = $_POST['resa']["end"];
     if ($rr->update($_POST)) {
+        $rri = new ReservationItem();
+        $rri->getFromDB($_POST['_item']);
+        $item = getItemForItemtype($rri->fields["itemtype"]);
+        $item->getFromDB($rri->fields["items_id"]);
         Event::log(
             $_POST["id"],
             "reservation",
             4,
             "inventory",
             //TRANS: %s is the user login
             sprintf(
-                __('%1$s updates the reservation for item %2$s'),
+                __('%1$s updates reservation %2$s for %3$s %4$s'),
                 $_SESSION["glpiname"],
-                $_POST['_item']
+                $_POST['id'],
+                $item::getTypeName(1),
+                $item->getNameID(['forceid' => true])
             )
         );
     }
@@ -114,16 +120,22 @@
 
     $reservationitems_id = key($_POST["items"]);
     if ($rr->delete($_POST, true)) {
+        $rri = new ReservationItem();
+        $rri->getFromDB($reservationitems_id);
+        $item = getItemForItemtype($rri->fields["itemtype"]);
+        $item->getFromDB($rri->fields["items_id"]);
         Event::log(
             $_POST["id"],
             "reservation",
             4,
             "inventory",
             //TRANS: %s is the user login
             sprintf(
-                __('%1$s purges the reservation for item %2$s'),
+                __('%1$s purges reservation %2$s for %3$s %4$s'),
                 $_SESSION["glpiname"],
-                $reservationitems_id
+                $_POST['id'],
+                $item::getTypeName(1),
+                $item->getNameID(['forceid' => true])
             )
         );
     }

src/Reservation.php

@@ -222,24 +222,24 @@ public static function handleAddForm(array $input): void
                 }
 
                 if ($newID = $rr->add($reservation_input)) {
+                    $rri = new ReservationItem();
+                    $rri->getFromDB($reservationitems_id);
+                    $item = getItemForItemtype($rri->fields["itemtype"]);
+                    $item->getFromDB($rri->fields["items_id"]);
+
                     Event::log(
                         $newID,
                         "reservation",
                         4,
                         "inventory",
                         sprintf(
-                            __s('%1$s adds the reservation %2$s for item %3$s'),
+                            __s('%1$s adds reservation %2$s for %3$s %4$s'),
                             $_SESSION["glpiname"],
                             $newID,
-                            $reservationitems_id
+                            $item::getTypeName(1),
+                            $item->getNameID(['forceid' => true])
                         )
                     );
-
-                    $rri = new ReservationItem();
-                    $rri->getFromDB($reservationitems_id);
-                    $item = getItemForItemtype($rri->fields["itemtype"]);
-                    $item->getFromDB($rri->fields["items_id"]);
-
                     Session::addMessageAfterRedirect(
                         sprintf(
                             __s('Reservation added for item %s at %s'),