Commit 10a86a0
Convert delete-preview action from Docker to composite (#21183)
* Convert delete-preview action from Docker to composite
Fix permission issues on GitHub-hosted runners by converting the
delete-preview action from a Docker container action to a composite
action. This resolves credential access problems where
GOOGLE_APPLICATION_CREDENTIALS set by setup-environment was not
accessible inside the Docker container.
Changes:
- Convert metadata.yml from 'using: docker' to 'using: composite'
- Move commands from entrypoint.sh to composite action steps
- Remove Dockerfile and entrypoint.sh (no longer needed)
- Preserve all functionality: previewctl install and delete-preview
The composite action runs directly on the runner, allowing proper
access to GCP credentials and environment variables set by the
setup-environment action.
Co-authored-by: Ona <[email protected]>
* Add container to delete job for leeway availability
The composite action requires leeway to be available, which is only
present in the dev-environment container. Run the entire delete job
in the container to provide leeway and other required tools.
This matches the pattern used in preview-env-gc.yml for the stale job.
Co-authored-by: Ona <[email protected]>
* Fix duplicate workflow runs on PR push
Remove push trigger and use pull_request with synchronize type to
prevent duplicate workflow runs when pushing to a PR branch.
Previously, both push and pull_request events fired when pushing to a
PR branch, causing the workflow to run twice in parallel.
Changes:
- Remove push trigger (branches-ignore: main)
- Add synchronize and reopened to pull_request types
- Keep opened and edited for PR creation and description updates
The synchronize event fires when commits are pushed to a PR branch,
replacing the need for the push trigger.
Co-authored-by: Ona <[email protected]>
* Add comment explaining pull_request trigger types
Document the purpose of each pull_request event type to clarify when
the workflow runs and why each type is needed.
Co-authored-by: Ona <[email protected]>
---------
Co-authored-by: Ona <[email protected]>1 parent e6bd727 commit 10a86a0
File tree
6 files changed
+34
-37
lines changed- .github
- actions/delete-preview
- workflows
6 files changed
+34
-37
lines changedThis file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
0 commit comments