Update all test files to use on.roles and on.bots format

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

pkg/workflow/compiler_orchestrator_test.go

@@ -608,12 +608,13 @@ func TestExtractAdditionalConfigurations(t *testing.T) {
 	tmpDir := testutil.TempDir(t, "additional-configs")
 
 	testContent := `---
-on: push
+on:
+  push: null
+  roles:
+    - admin
+  bots:
+    - copilot
 engine: copilot
-roles:
-  - admin
-bots:
-  - copilot
 ---
 
 # Test Workflow

pkg/workflow/compiler_orchestrator_workflow_test.go

@@ -1098,46 +1098,13 @@ on:
   pull_request:
     types: [opened, synchronize]
     draft: false
+  roles:
+    - admin
+    - maintainer
+  bots:
+    - copilot
+    - dependabot
 engine: copilot
-name: Complete Workflow
-description: Test all sections
-source: complete-test
-timeout-minutes: 60
-strict: false
-features:
-  dangerous-permissions-write: true
-permissions:
-  contents: read
-  issues: write
-  pull-requests: write
-network:
-  allowed:
-    - github.com
-    - api.example.com
-concurrency:
-  group: ci-${{ github.ref }}
-  cancel-in-progress: true
-run-name: Test Run ${{ github.run_id }}
-env:
-  NODE_ENV: production
-  DEBUG: "true"
-if: github.event_name == 'push'
-runs-on: ubuntu-latest
-environment: production
-container: node:18
-cache:
-  - key: ${{ runner.os }}-node
-    path: node_modules
-tools:
-  bash: ["echo", "ls", "cat"]
-  github:
-    allowed: [list_issues, create_issue]
-roles:
-  - admin
-  - maintainer
-bots:
-  - copilot
-  - dependabot
 steps:
   - name: Custom step
     run: echo "test"

pkg/workflow/permission_restriction_test.go

@@ -67,7 +67,7 @@ Test workflow content.`,
 on:
   push:
     branches: [main]
-roles: all
+  roles: all
 tools:
   github:
     allowed: [list_issues]
@@ -85,7 +85,7 @@ Test workflow content.`,
 on:
   pull_request:
     types: [opened]
-roles: [admin, maintainer, write]
+  roles: [admin, maintainer, write]
 tools:
   github:
     allowed: [list_issues]
@@ -101,8 +101,8 @@ Test workflow content.`,
 			name: "workflow with workflow_dispatch only should NOT include permission check (safe event)",
 			frontmatter: `---
 on:
-  workflow_dispatch:
-roles: [admin, maintainer, write]
+  workflow_dispatch: null
+  roles: [admin, maintainer, write]
 tools:
   github:
     allowed: [list_issues]
@@ -118,8 +118,8 @@ Test workflow content.`,
 			name: "workflow with workflow_dispatch without write role should include permission check",
 			frontmatter: `---
 on:
-  workflow_dispatch:
-roles: [admin, maintainer]
+  workflow_dispatch: null
+  roles: [admin, maintainer]
 tools:
   github:
     allowed: [list_issues]
@@ -190,8 +190,8 @@ Test workflow content.`,
 on:
   command:
     name: scout
-  workflow_dispatch:
-roles: [admin, maintainer, write]
+  workflow_dispatch: null
+  roles: [admin, maintainer, write]
 tools:
   github:
     allowed: [list_issues]

pkg/workflow/pre_activation_custom_fields_test.go

@@ -22,10 +22,10 @@ func TestPreActivationCustomSteps(t *testing.T) {
 	t.Run("custom_steps_imported", func(t *testing.T) {
 		workflowContent := `---
 on:
-  workflow_dispatch:
+  workflow_dispatch: null
   stop-after: "+48h"
+  roles: [admin, maintainer]
 engine: claude
-roles: [admin, maintainer]
 jobs:
   pre-activation:
     steps:
@@ -74,10 +74,10 @@ Test workflow with custom pre-activation steps
 	t.Run("custom_outputs_imported", func(t *testing.T) {
 		workflowContent := `---
 on:
-  workflow_dispatch:
+  workflow_dispatch: null
   stop-after: "+48h"
+  roles: [admin, maintainer]
 engine: claude
-roles: [admin, maintainer]
 jobs:
   pre-activation:
     outputs:
@@ -121,8 +121,8 @@ Test workflow with custom pre-activation outputs
 on:
   workflow_dispatch:
   stop-after: "+48h"
+  roles: [admin, maintainer]
 engine: claude
-roles: [admin, maintainer]
 jobs:
   pre-activation:
     steps:
@@ -168,8 +168,8 @@ Test workflow with both custom steps and outputs
 on:
   workflow_dispatch:
   stop-after: "+48h"
+  roles: [admin, maintainer]
 engine: claude
-roles: [admin, maintainer]
 jobs:
   pre-activation:
     runs-on: ubuntu-latest
@@ -201,8 +201,8 @@ Test workflow with unsupported field in pre-activation
 on:
   workflow_dispatch:
   stop-after: "+48h"
+  roles: [admin, maintainer]
 engine: claude
-roles: [admin, maintainer]
 jobs:
   pre-activation:
     steps:
@@ -255,8 +255,8 @@ Test that pre-activation is not added as a custom job
 on:
   workflow_dispatch:
   stop-after: "+48h"
+  roles: [admin, maintainer]
 engine: claude
-roles: [admin, maintainer]
 jobs:
   pre-activation:
     steps:

pkg/workflow/processing_benchmark_test.go

@@ -288,8 +288,9 @@ func BenchmarkProcessRoles(b *testing.B) {
 	defer os.RemoveAll(tmpDir)
 
 	testContent := `---
-on: issues
-roles: [admin, maintainer, write, read]
+on:
+  issues: null
+  roles: [admin, maintainer, write, read]
 permissions:
   contents: read
   issues: write

pkg/workflow/role_checks_test.go

@@ -115,7 +115,7 @@ on:
   pull_request:
     types: [opened]
   roles: [write]
-bots: ["dependabot[bot]"]
+  bots: ["dependabot[bot]"]
 ---
 
 # Test Workflow

pkg/workflow/skip_bots_test.go

@@ -133,7 +133,7 @@ on:
   issues:
     types: [opened]
   skip-bots: [user1, user2]
-roles: [maintainer]
+  roles: [maintainer]
 engine: copilot
 ---
 

pkg/workflow/skip_if_match_test.go

@@ -87,10 +87,10 @@ This workflow has a skip-if-match configuration.
 	t.Run("pre_activation_job_with_multiple_checks", func(t *testing.T) {
 		workflowContent := `---
 on:
-  workflow_dispatch:
+  workflow_dispatch: null
   stop-after: "+48h"
   skip-if-match: "is:pr is:open"
-roles: [admin, maintainer]
+  roles: [admin, maintainer]
 engine: claude
 ---
 

pkg/workflow/skip_if_no_match_test.go

@@ -92,10 +92,10 @@ This workflow has a skip-if-no-match configuration.
 	t.Run("pre_activation_job_with_multiple_checks", func(t *testing.T) {
 		workflowContent := `---
 on:
-  workflow_dispatch:
+  workflow_dispatch: null
   stop-after: "+48h"
   skip-if-no-match: "is:pr is:open label:urgent"
-roles: [admin, maintainer]
+  roles: [admin, maintainer]
 engine: claude
 ---
 

pkg/workflow/stop_time_check_job_test.go

@@ -22,9 +22,9 @@ func TestPreActivationJob(t *testing.T) {
 	t.Run("pre_activation_job_created_with_stop_after", func(t *testing.T) {
 		workflowContent := `---
 on:
-  workflow_dispatch:
+  workflow_dispatch: null
   stop-after: "+48h"
-roles: [admin, maintainer]
+  roles: [admin, maintainer]
 engine: claude
 ---
 
@@ -105,9 +105,9 @@ This workflow has a stop-after configuration.
 	t.Run("no_pre_activation_job_without_stop_after_or_roles", func(t *testing.T) {
 		workflowContent := `---
 on:
-  workflow_dispatch:
+  workflow_dispatch: null
+  roles: all
 engine: claude
-roles: all
 ---
 
 # Normal Workflow