Extract duplicate shortenCommand() to shared utility function (#2682)

Author: Copilot

.changeset/patch-extract-shorten-command-utility.md

@@ -387,7 +387,7 @@ func (e *ClaudeEngine) parseToolCallsWithSequence(contentArray []any, toolCallMa
 											if command, exists := inputMap["command"]; exists {
 												if commandStr, ok := command.(string); ok {
 													// Create unique bash entry with command info, avoiding colons
-													uniqueBashName := fmt.Sprintf("bash_%s", e.shortenCommand(commandStr))
+													uniqueBashName := fmt.Sprintf("bash_%s", ShortenCommand(commandStr))
 													prettifiedName = uniqueBashName
 												}
 											}
@@ -472,7 +472,7 @@ func (e *ClaudeEngine) parseToolCalls(contentArray []any, toolCallMap map[string
 											if command, exists := inputMap["command"]; exists {
 												if commandStr, ok := command.(string); ok {
 													// Create unique bash entry with command info, avoiding colons
-													uniqueBashName := fmt.Sprintf("bash_%s", e.shortenCommand(commandStr))
+													uniqueBashName := fmt.Sprintf("bash_%s", ShortenCommand(commandStr))
 													prettifiedName = uniqueBashName
 												}
 											}
@@ -531,16 +531,6 @@ func (e *ClaudeEngine) parseToolCalls(contentArray []any, toolCallMap map[string
 	}
 }
 
-// shortenCommand creates a short identifier for bash commands
-func (e *ClaudeEngine) shortenCommand(command string) string {
-	// Take first 20 characters and remove newlines
-	shortened := strings.ReplaceAll(command, "\n", " ")
-	if len(shortened) > 20 {
-		shortened = shortened[:20] + "..."
-	}
-	return shortened
-}
-
 // estimateInputSize estimates the input size in tokens from a tool input object
 func (e *ClaudeEngine) estimateInputSize(input any) int {
 	// Convert input to JSON string to get approximate size

pkg/workflow/claude_logs.go

@@ -391,7 +391,7 @@ func (e *CodexEngine) parseCodexToolCallsWithSequence(line string, toolCallMap m
 
 	if execCommand != "" {
 		// Create unique bash entry with command info, avoiding colons
-		uniqueBashName := fmt.Sprintf("bash_%s", e.shortenCommand(execCommand))
+		uniqueBashName := fmt.Sprintf("bash_%s", ShortenCommand(execCommand))
 
 		// Initialize or update tool call info
 		if toolInfo, exists := toolCallMap[uniqueBashName]; exists {
@@ -440,16 +440,6 @@ func (e *CodexEngine) updateMostRecentToolWithDuration(toolCallMap map[string]*T
 	}
 }
 
-// shortenCommand creates a short identifier for bash commands
-func (e *CodexEngine) shortenCommand(command string) string {
-	// Take first 20 characters and remove newlines
-	shortened := strings.ReplaceAll(command, "\n", " ")
-	if len(shortened) > 20 {
-		shortened = shortened[:20] + "..."
-	}
-	return shortened
-}
-
 // extractCodexTokenUsage extracts token usage from Codex-specific log lines
 func (e *CodexEngine) extractCodexTokenUsage(line string) int {
 	// Codex format: "tokens used: 13934"

pkg/workflow/codex_engine.go

@@ -47,3 +47,14 @@ func SanitizeWorkflowName(name string) string {
 
 	return name
 }
+
+// ShortenCommand creates a short identifier for bash commands.
+// It replaces newlines with spaces and truncates to 20 characters if needed.
+func ShortenCommand(command string) string {
+	// Take first 20 characters and remove newlines
+	shortened := strings.ReplaceAll(command, "\n", " ")
+	if len(shortened) > 20 {
+		shortened = shortened[:20] + "..."
+	}
+	return shortened
+}

pkg/workflow/strings.go

@@ -89,3 +89,61 @@ func TestSanitizeWorkflowName(t *testing.T) {
 		})
 	}
 }
+
+func TestShortenCommand(t *testing.T) {
+	tests := []struct {
+		name     string
+		input    string
+		expected string
+	}{
+		{
+			name:     "short command",
+			input:    "ls -la",
+			expected: "ls -la",
+		},
+		{
+			name:     "exactly 20 characters",
+			input:    "12345678901234567890",
+			expected: "12345678901234567890",
+		},
+		{
+			name:     "long command gets truncated",
+			input:    "this is a very long command that exceeds the limit",
+			expected: "this is a very long ...",
+		},
+		{
+			name:     "newlines replaced with spaces",
+			input:    "echo hello\nworld",
+			expected: "echo hello world",
+		},
+		{
+			name:     "multiple newlines",
+			input:    "line1\nline2\nline3",
+			expected: "line1 line2 line3",
+		},
+		{
+			name:     "long command with newlines",
+			input:    "echo this is\na very long\ncommand with newlines",
+			expected: "echo this is a very ...",
+		},
+		{
+			name:     "empty string",
+			input:    "",
+			expected: "",
+		},
+		{
+			name:     "only newlines",
+			input:    "\n\n\n",
+			expected: "   ",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := ShortenCommand(tt.input)
+			if result != tt.expected {
+				t.Errorf("ShortenCommand(%q) = %q, want %q", tt.input, result, tt.expected)
+			}
+		})
+	}
+}