Skip to content

Commit 5b953fa

Browse files
Copilotpelikhan
andauthored
[WIP] Fix failing GitHub Actions workflow for integration (#15731)
* Initial plan * Fix Docker daemon check in integration tests - Update TestValidateContainerImages to check Docker daemon status - Update TestValidateDockerImage to check Docker daemon status - Use isDockerDaemonRunning() function to match validation code behavior - Tests now properly skip when Docker daemon is not running (not just when binary is missing) Co-authored-by: pelikhan <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pelikhan <[email protected]> Co-authored-by: Peli de Halleux <[email protected]>
1 parent 3dfa565 commit 5b953fa

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

pkg/workflow/validation_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,15 @@ func TestValidateContainerImages(t *testing.T) {
6363

6464
for _, tt := range tests {
6565
t.Run(tt.name, func(t *testing.T) {
66-
// Skip test if docker is not available
66+
// Skip test if docker daemon is not running
6767
if tt.skipIfNoDocker {
6868
if _, err := exec.LookPath("docker"); err != nil {
6969
t.Skip("docker not available, skipping test")
7070
}
71+
// Also check if Docker daemon is running (not just if binary exists)
72+
if !isDockerDaemonRunning() {
73+
t.Skip("docker daemon not running, skipping test")
74+
}
7175
}
7276

7377
compiler := NewCompiler()
@@ -88,6 +92,10 @@ func TestValidateDockerImage(t *testing.T) {
8892
if _, err := exec.LookPath("docker"); err != nil {
8993
t.Skip("docker not available, skipping test")
9094
}
95+
// Also check if Docker daemon is running (not just if binary exists)
96+
if !isDockerDaemonRunning() {
97+
t.Skip("docker daemon not running, skipping test")
98+
}
9199

92100
tests := []struct {
93101
name string

0 commit comments

Comments
 (0)