Skip to content

Commit c091c03

Browse files
committed
todo
1 parent e273159 commit c091c03

1 file changed

Lines changed: 23 additions & 0 deletions

File tree

shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -848,6 +848,29 @@ module Make<
848848
* Argument[0].Parameter[1].Field[A].Field[B]
849849
* ```
850850
*
851+
* TODO: turn this into
852+
*
853+
* ```
854+
* Field[A].Field[B].Parameter[1].Argument[0]
855+
* ```
856+
*
857+
* so we can process the stack top-down.
858+
*
859+
*
860+
* For a sink access path like
861+
*
862+
* ```
863+
* Argument[0].ReturnValue.Field[A].Field[B]
864+
* ```
865+
*
866+
* TODO: turn this into
867+
*
868+
* ```
869+
* Field[B].Field[A].ReturnValue.Argument[0]
870+
* ```
871+
*
872+
* so we can process the stack top-down.
873+
*
851874
* We want flow to start at the element corresponding to the first argument, then
852875
* proceed to the parameter of the callback referred to by that argument, then a
853876
* store into `A`, and finally a store into `B`.

0 commit comments

Comments
 (0)