Commit 52170ca
test(javascript): Update test for Symbolicator change (#97069)
A recent sourcemap bug fix
(getsentry/rust-sourcemap#129) results in some
minified lines/columns being (correctly) unmapped. We cannot incorporate
this bug fix into Symbolicator without first adjusting these tests
because they are also run in the Symbolicator repo.
This PR temporarily removes assertions about the unmapped frames so we
can merge the fix (it's contained in
getsentry/symbolicator#1749). After Symbolicator
is merged we can properly assert that the frames in question are
unmapped.
As a side note, this entire test is somewhat bizarre. It was added in
c5d2742 in more or less its current
form. The first frame the test attempts to map has line 9 and column
2321, but no line in the source file fixture has that many columns (the
test works regardless, but still, I can't fathom what the idea behind
this is).
Moreover, the fixture apparently got reformatted by mistake in the
unrelated 6c11c9b, which makes no
difference to the correctness of the test but makes it very confusing if
you look at it in a sourcemap visualizer. Therefore we also restore the
original fixture here.1 parent e116a23 commit 52170ca
File tree
2 files changed
+2033
-2141
lines changed- tests/relay_integration/lang/javascript
- fixtures
2 files changed
+2033
-2141
lines changed
0 commit comments