Skip to content

Commit f83f288

Browse files
authored
test(angular): Fix failing canary test (#19639)
The actual fail mostly "resolved itself" because Angular now also released `22.0.0-next.0` versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will [require](angular/angular-cli#32681) At least Node 22.22.0. So this PR makes a few modifications to fully fix Angular canary tests again: - set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO) - Use the `angular-21` app instead of the `angular-20` app for canary tests - Remove the optional canary test config in the `angular-20` app closes #19636
1 parent 2b3ce34 commit f83f288

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

.github/workflows/canary.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ jobs:
6969
fail-fast: false
7070
matrix:
7171
include:
72-
- test-application: 'angular-20'
72+
- test-application: 'angular-21'
7373
build-command: 'test:build-canary'
74-
label: 'angular-20 (next)'
74+
label: 'angular-21 (next)'
7575
- test-application: 'create-react-app'
7676
build-command: 'test:build-canary'
7777
label: 'create-react-app (canary)'
@@ -130,7 +130,6 @@ jobs:
130130
with:
131131
version: 9.15.9
132132
- name: Set up Node
133-
if: matrix.test-application != 'angular-20'
134133
uses: actions/setup-node@v6
135134
with:
136135
node-version-file: 'dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/package.json'

dev-packages/e2e-tests/test-applications/angular-20/package.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"watch": "ng build --watch --configuration development",
1111
"test": "playwright test",
1212
"test:build": "pnpm install && pnpm build",
13-
"test:build-canary": "pnpm install && pnpm add @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next && pnpm build",
1413
"test:assert": "playwright test",
1514
"clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
1615
},
@@ -48,13 +47,5 @@
4847
},
4948
"volta": {
5049
"extends": "../../package.json"
51-
},
52-
"sentryTest": {
53-
"optionalVariants": [
54-
{
55-
"build-command": "pnpm test:build-canary",
56-
"label": "angular (canary)"
57-
}
58-
]
5950
}
6051
}

dev-packages/e2e-tests/test-applications/angular-21/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
"typescript": "~5.9.0"
4848
},
4949
"volta": {
50+
"node": "22.22.0",
5051
"extends": "../../package.json"
5152
},
5253
"sentryTest": {

0 commit comments

Comments
 (0)