Merge pull request #632 from geoadmin/fix-PB-2201-collection-patch

Fix PATCH collections

Author: benschs

app/stac_api/serializers/collection.py

@@ -360,16 +360,20 @@ def create(self, validated_data):
     def update(self, instance, validated_data):
         """
         Update and return an existing `Collection` instance, given the validated data.
+        In case of partial update, only update providers and links if they are present
+        in the payload.
         """
-        providers_data = validated_data.pop('providers', [])
-        links_data = validated_data.pop('links', [])
-        self._update_or_create_providers(collection=instance, providers_data=providers_data)
-        update_or_create_links(
-            instance_type="collection",
-            model=CollectionLink,
-            instance=instance,
-            links_data=links_data
-        )
+        if not self.partial or validated_data.get('providers') is not None:
+            providers_data = validated_data.pop('providers', [])
+            self._update_or_create_providers(collection=instance, providers_data=providers_data)
+        if not self.partial or validated_data.get('links') is not None:
+            links_data = validated_data.pop('links', [])
+            update_or_create_links(
+                instance_type="collection",
+                model=CollectionLink,
+                instance=instance,
+                links_data=links_data
+            )
         return super().update(instance, validated_data)
 
     def update_or_create(self, look_up, validated_data):

app/tests/tests_10/test_collections_endpoint.py

@@ -402,6 +402,8 @@ def test_collection_patch(self):
         self.assertNotEqual(self.collection["license"], payload_json['license'])
         # for start the payload has no description
         self.assertNotIn('title', payload_json.keys())
+        providers_before_patch = self.collection['providers']
+        links_before_patch = self.collection['links']
 
         response = self.client.patch(
             f"/{STAC_BASE_V}/collections/{collection_name}",
@@ -413,8 +415,13 @@ def test_collection_patch(self):
         # licence affected by patch
         self.assertEqual(payload_json['license'], response_json['license'])
 
+        db_collection = Collection.objects.get(name=collection_name)
         # description not affected by patch
         self.assertEqual(self.collection["description"], response_json['description'])
+        # providers not affected by patch
+        self.assertEqual(db_collection.providers.count(), len(providers_before_patch))
+        # links not affected by patch
+        self.assertEqual(db_collection.links.count(), len(links_before_patch))
 
     def test_collection_patch_extra_payload(self):
         collection_name = self.collection['name']  # get a name that is registered in the service