Add some tests that highlight bugs with QB and save/sync. (#927)

Author: vpetrovykh

tests/test_model_generator.py

@@ -6667,6 +6667,88 @@ def test_modelgen_sync_warning(self):
         with self.assertNotWarns():
             self.client.sync(g, warn_on_large_sync=False)
 
+    @tb.xfail('''
+        The save seems to fail for objects fetched via a computed link.
+    ''')
+    def test_modelgen_computed_01(self):
+        from models.orm import default
+
+        # Fetch the user with linked computed groups. Then use one of the
+        # fetched groups to remove the user from it. Save. Check.
+
+        alice = self.client.get(
+            default.User.select(
+                "*",
+                groups=lambda u: u.groups.select(
+                    "*",
+                    users=True,
+                )
+            ).filter(name="Alice")
+        )
+
+        for g in alice.groups:
+            if g.name == "red":
+                g.users.remove(alice)
+                self.assertEqual(
+                    [u.name for u in g.users],
+                    ['Billie', 'Cameron', 'Dana'],
+                )
+                self.client.save(g)
+                break
+
+        refetch = self.client.get(
+            default.User.select(
+                "*",
+                groups=True,
+            ).filter(name="Alice")
+        )
+        self.assertEqual(refetch.name, "Alice")
+        self.assertEqual([g.name for g in refetch.groups], ["green"])
+
+    @tb.xfail('''
+        The sync seems to ignore objects fetched via a computed link
+        even though the objects are being explicitly added to the sync
+        arguments.
+    ''')
+    def test_modelgen_computed_02(self):
+        from models.orm import default
+
+        # Fetch the user with linked computed groups. Then use one of the
+        # fetched groups to remove the user from it. Sync. Check.
+
+        alice = self.client.get(
+            default.User.select(
+                "*",
+                groups=lambda u: u.groups.select(
+                    "*",
+                    users=True,
+                )
+            ).filter(name="Alice")
+        )
+
+        for g in alice.groups:
+            if g.name == "red":
+                g.users.remove(alice)
+                self.assertEqual(
+                    [u.name for u in g.users],
+                    ['Billie', 'Cameron', 'Dana'],
+                )
+                break
+
+        self.client.sync(*alice.groups, alice)
+
+        self.assertEqual(alice.name, "Alice")
+        self.assertEqual([g.name for g in alice.groups], ["green"])
+
+        # double-check the group directly
+        red = self.client.get(
+            default.UserGroup.select(users=True).filter(name="red")
+        )
+        self.assertEqual(
+            [u.name for u in red.users],
+            ['Billie', 'Cameron', 'Dana'],
+        )
+
 
 @tb.typecheck
 class TestEmptyModelGenerator(tb.ModelTestCase):

tests/test_qb.py

@@ -892,6 +892,29 @@ def test_qb_filter_12(self):
         res = sess_client.query(q)
         self.assertEqual(len(res), 2)
 
+    @tb.xfail('''
+        std.union seems to fail in the filter
+
+        TypeError: issubclass() arg 2 must be a class, a tuple of classes,
+        or a union
+    ''')
+    def test_qb_filter_13(self):
+        from models.orm import default, std
+
+        # Create a complex filter expression using some std functions and an
+        # unrelated subquery
+        dana = default.User.filter(name="Dana")
+        res = self.client.get(
+            default.UserGroup.filter(
+                lambda g: std.count(
+                    std.distinct(
+                        std.union(g.users, dana)
+                    )
+                ) == 3
+            )
+        )
+        self.assertEqual(res.name, "green")
+
     def test_qb_link_property_01(self):
         from models.orm import default