Skip to content

Commit 0194d19

Browse files
authored
Fix validation of Range (#943)
We should return the underlying range type, not the _pydantic._types.Range.
1 parent a92291a commit 0194d19

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

gel/_internal/_qbmodel/_pydantic/_types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def _validate(cls, eltype: type, value: Any) -> _range.Range[_T]:
151151
return value
152152

153153
elif isinstance(value, dict):
154-
return cls(
154+
return _range.Range(
155155
lower=cls._validate_bound(eltype, value["lower"]),
156156
upper=cls._validate_bound(eltype, value["upper"]),
157157
inc_lower=value["inc_lower"],

tests/test_model_generator.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3962,7 +3962,7 @@ def test_modelgen_save_reload_props_04(self):
39623962
self.client.save(tpr)
39633963

39643964
tpr.model_dump()
3965-
self.assertPydanticSerializes(tpr, test_pickle=False)
3965+
self.assertPydanticSerializes(tpr)
39663966

39673967
def test_modelgen_save_reload_links_01(self):
39683968
from models.orm import default
@@ -4909,9 +4909,8 @@ def test_modelgen_save_range_01(self):
49094909
Range(dt.date(2025, 1, 6), dt.date(2025, 2, 17)),
49104910
)
49114911

4912-
# FIXME: pickle is broken for ranges
4913-
self.assertPydanticSerializes(r, test_pickle=False)
4914-
self.assertPydanticSerializes(r2, test_pickle=False)
4912+
self.assertPydanticSerializes(r)
4913+
self.assertPydanticSerializes(r2)
49154914

49164915
def test_modelgen_save_range_02(self):
49174916
import datetime as dt

0 commit comments

Comments
 (0)