-
Notifications
You must be signed in to change notification settings - Fork 57
invalid checkstyle configuration #310
Description
The checkstyle configuration of this project demands newlines to be LF, but doesn't enforce the same setting in the git config:
modernizer-maven-plugin/modernizer-maven-policy/src/main/resources/checkstyle/checkstyle.xml
Line 14 in aa3cf2b
| <property name="lineSeparator" value="lf" /> |
Therefore anyone checking out this project on Windows may get checkstyle failures, depending on whether or not autocrlf is set or not in the personal git config.
What's your preferred way of fixing this? Removing the checkstyle property? Adding a gitconfig which enforces the LF newline? I'd recommend removing the property, and eventually adding another check instead which prohibits mixed line endings, but doesn't care about the kind of local line ending. I would not recommend to try enforcing a specific git configuration, as this always leads to trouble with other projects on the same machine, or company settings, or...
