Give the triggers and conditions an icon

Ten triggers and seven conditions shipped without any, because Spook had no
`icons.json` at all. Nothing failed and nothing logged it: they simply drew
without an icon, and the only way to notice was to open the automation editor
and look, which is how Frenck found it.

Each one is picked for what it does rather than what it is called, taken from
the descriptions in the translations. `watchdog` fires when something expected
does not happen in time, so it is a timer with an alert and not a dog.
Integrations are a puzzle piece the way Home Assistant draws them, the three
repair ones share the wrench family the repairs sensors already use, and
`triggered_by_user` and `triggered_by_automation` borrow the account and robot
that Home Assistant uses for people and automations.

Every name was checked against the icon set the frontend ships, off a real
installation's `iconList.json`, because a misspelled icon renders as an empty
square and reports nothing. All seventeen exist.

A test compares the icons against the translations in both directions, so the
next trigger added either gets an icon or fails the build. Five mutations
caught: dropping a trigger, dropping a condition, misspelling an icon, naming
the wrong kind, and adding an icon for something that does not exist.

Author: frenck

custom_components/spook/icons.json

@@ -0,0 +1,57 @@
+{
+  "conditions": {
+    "chance": {
+      "condition": "mdi:dice-multiple"
+    },
+    "cooldown": {
+      "condition": "mdi:timer-sand"
+    },
+    "not_triggered_by_user": {
+      "condition": "mdi:account-off"
+    },
+    "quota": {
+      "condition": "mdi:gauge"
+    },
+    "repair_issue_present": {
+      "condition": "mdi:wrench-clock"
+    },
+    "triggered_by_automation": {
+      "condition": "mdi:robot"
+    },
+    "triggered_by_user": {
+      "condition": "mdi:account"
+    }
+  },
+  "triggers": {
+    "condition_met": {
+      "trigger": "mdi:check-circle"
+    },
+    "cron": {
+      "trigger": "mdi:calendar-clock"
+    },
+    "flapping": {
+      "trigger": "mdi:sine-wave"
+    },
+    "integration_failed": {
+      "trigger": "mdi:puzzle-remove"
+    },
+    "repair_issue_created": {
+      "trigger": "mdi:wrench"
+    },
+    "repair_issue_removed": {
+      "trigger": "mdi:wrench-check"
+    },
+    "sequence": {
+      "trigger": "mdi:format-list-numbered"
+    },
+    "stale": {
+      "trigger": "mdi:signal-off"
+    },
+    "watchdog": {
+      "trigger": "mdi:timer-alert"
+    },
+    "while": {
+      "trigger": "mdi:repeat"
+    }
+  }
+}

tests/test_icons.py

@@ -0,0 +1,58 @@
+"""Tests that every trigger and condition Spook adds has an icon.
+
+Spook shipped ten triggers and seven conditions with no `icons.json` at all,
+so every one of them rendered without an icon. Nothing failed and nothing
+logged: the only way to notice was to open the automation editor and look.
+"""
+
+# pylint: disable=wrong-import-order
+from __future__ import annotations
+
+import json
+from pathlib import Path
+import re
+
+import pytest
+
+SPOOK = Path(__file__).parents[1] / "custom_components" / "spook"
+ICONS = json.loads((SPOOK / "icons.json").read_text())
+STRINGS = json.loads((SPOOK / "translations" / "en.json").read_text())
+
+# Home Assistant keys these by kind, and the value names the kind again.
+_SECTIONS = (("triggers", "trigger"), ("conditions", "condition"))
+
+# An `mdi:` name, lowercase with single hyphens, which is all Material Design
+# Icons uses. A typo here renders as an empty square rather than an error.
+_MDI = re.compile(r"\Amdi:[a-z0-9]+(-[a-z0-9]+)*\Z")
+
+
+def test_there_is_something_to_check() -> None:
+    """Guard the lookups, which would pass happily against an empty file."""
+    assert ICONS
+    for section, _ in _SECTIONS:
+        assert STRINGS[section], section
+
+
+@pytest.mark.parametrize(("section", "kind"), _SECTIONS)
+def test_everything_translated_also_has_an_icon(section: str, kind: str) -> None:
+    """The translations are the list of what Spook actually adds."""
+    described = set(STRINGS[section])
+    iconed = set(ICONS.get(section, {}))
+
+    assert not described - iconed, (
+        f"{section} without an icon: {sorted(described - iconed)}"
+    )
+    assert not iconed - described, (
+        f"{section} with an icon and nothing else: {sorted(iconed - described)}"
+    )
+
+    for key, entry in ICONS[section].items():
+        assert kind in entry, f"{section}.{key} does not name its {kind}"
+
+
+@pytest.mark.parametrize(("section", "kind"), _SECTIONS)
+def test_every_icon_is_shaped_like_an_mdi_name(section: str, kind: str) -> None:
+    """A misspelled icon shows an empty square, which nothing reports."""
+    for key, entry in ICONS[section].items():
+        icon = entry[kind]
+        assert _MDI.match(icon), f"{section}.{key} has {icon!r}"