fix: custom error messages for rewrites (include path), full invalid JSON test

lesya7 · cursoragent · lesya7 · commit 0017132224a2 · 2026-02-12T12:31:44.000-08:00
Co-authored-by: Cursor &lt;cursoragent@cursor.com&gt;
diff --git a/src/resolve/adapters/webApplicationsSourceAdapter.ts b/src/resolve/adapters/webApplicationsSourceAdapter.ts
@@ -167,7 +167,10 @@ export class WebApplicationsSourceAdapter extends BundleSourceAdapter {
         if (rewrite) {
           const rewritePath = join(outputDirPath, stripLeadingSep(rewrite));
           if (!this.tree.exists(rewritePath)) {
-            this.expectedSourceError(rewritePath);
+            throw new SfError(
+              `A rewrite target defined in webapplication.json -> routing.rewrites was not found: ${rewritePath}. Ensure the file exists at that location.`,
+              'ExpectedSourceFilesError'
+            );
           }
         }
       }
diff --git a/test/resolve/adapters/webApplicationsSourceAdapter.test.ts b/test/resolve/adapters/webApplicationsSourceAdapter.test.ts
@@ -214,7 +214,7 @@ describe('WebApplicationsSourceAdapter', () => {
       );
     };
 
-    it('should throw on malformed JSON', () => {
+    it('should throw on malformed JSON with full error detail', () => {
       const vfs: VirtualDirectory[] = [
         {
           dirPath: APP_PATH,
@@ -230,7 +230,11 @@ describe('WebApplicationsSourceAdapter', () => {
         forceIgnore,
         new VirtualTreeContainer(vfs)
       );
-      assert.throws(() => a.getComponent(APP_PATH), SfError, 'Invalid JSON in webapplication.json');
+      assert.throws(
+        () => a.getComponent(APP_PATH),
+        SfError,
+        /^Invalid JSON in webapplication\.json: .+/
+      );
     });
 
     it('should throw when outputDir is missing', () => {
@@ -306,13 +310,11 @@ describe('WebApplicationsSourceAdapter', () => {
       const a = adapterWith(config, [
         { dirPath: DIST_PATH, children: [{ name: 'index.html', data: Buffer.from('<html>test</html>') }] },
       ]);
+      const expectedPath = join(DIST_PATH, 'missing-rewrite.html');
       assert.throws(
         () => a.getComponent(APP_PATH),
         SfError,
-        messages.getMessage('error_expected_source_files', [
-          join(DIST_PATH, 'missing-rewrite.html'),
-          registry.types.webapplication.name,
-        ])
+        `A rewrite target defined in webapplication.json -> routing.rewrites was not found: ${expectedPath}. Ensure the file exists at that location.`
       );
     });
 
@@ -414,13 +416,11 @@ describe('WebApplicationsSourceAdapter', () => {
         ],
       };
       const a = adapterWith(config, [distDir]);
+      const expectedPath = join(DIST_PATH, 'missing-docs.html');
       assert.throws(
         () => a.getComponent(APP_PATH),
         SfError,
-        messages.getMessage('error_expected_source_files', [
-          join(DIST_PATH, 'missing-docs.html'),
-          registry.types.webapplication.name,
-        ])
+        `A rewrite target defined in webapplication.json -> routing.rewrites was not found: ${expectedPath}. Ensure the file exists at that location.`
       );
     });
   });

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,10 @@ export class WebApplicationsSourceAdapter extends BundleSourceAdapter {`
`167`	`167`	`if (rewrite) {`
`168`	`168`	`const rewritePath = join(outputDirPath, stripLeadingSep(rewrite));`
`169`	`169`	`if (!this.tree.exists(rewritePath)) {`
`170`		`- this.expectedSourceError(rewritePath);`
	`170`	`+ throw new SfError(`
	`171`	+ `A rewrite target defined in webapplication.json -> routing.rewrites was not found: ${rewritePath}. Ensure the file exists at that location.`,
	`172`	`+ 'ExpectedSourceFilesError'`
	`173`	`+ );`
`171`	`174`	`}`
`172`	`175`	`}`
`173`	`176`	`}`