Implementation new K8s Events API - v1

[adri1197]

Transition the Flux ecosystem from legacy core/v1 events to the modern events.k8s.io/v1 API. The following changes have to follow a backward compatibility approach where legacy fields may be bridged to the new schema (e.g., keep InvolvedObject regardless of being renamed, add a new RelatedObject field) to ensure no breaking changes for users relying on current event logs.

Action Items

• Update fluxcd/pkg to use events.k8s.io/v1 - runtime: Migrate to new Kubernentes event API pkg#1144
• Update fluxcd/notification-controller to capture the events and populate properly the fields (backward compatible) - Migrate to new Kubernetes events API notification-controller#1267
  • Adapt the event receiver to handle the events.k8s.io/v1 schema.
  • Update spec/v1beta3/events.md to document new fields.
• Update all controllers using the changes done in runtime/events from fluxcd/pkg. Use new field relatedObject to include object's source metadata (as InvolvedObject does) and Action as mandatory field.
  • Mandatory controllers
    • Helm-Controller
    • Kustomize-Controller Migrate event recorder to fluxcd/pkg/runtime/events.Recorder kustomize-controller#1621
    • Source-Controller Migrate event recorder to event/v1 source-controller#2011
  • Optional controllers
    • Source-Watcher
    • Image-Automation-Controller
    • Image-Reflector-Controller

Reference to the new API spec and changes

• API Deprecation Guide ( events.k8s.io/v1beta1 deprecated since k8s 1.25)
• KEP-383: New Event API GA Graduation

[adri1197]

Hi @matheuscscp,

You were right that the k8s.io/client-go/tools/events interface doesn't support setting annotations, so we should stick with a simple Eventf. I'm looking into whether it would be feasible to propose bringing the AnnotationEventf function back upstream in Kubernetes.

In any case, I don't think this should be a major issue, since we can still send the annotation to notification-controller using github.com/fluxcd/pkg/apis/event/v1. I'll need to rework some of the controller test cases so they don't rely on annotations to filter Kubernetes events.

[matheuscscp]

Does this mean we're losing support for annotations in k8s events?