chat - some fixes to setup and quotas (microsoft#235457)

Author: bpasero

src/vs/workbench/contrib/chat/browser/chatQuotasService.ts

@@ -32,6 +32,7 @@ export interface IChatQuotasService {
 	readonly quotas: IChatQuotas;
 
 	acceptQuotas(quotas: IChatQuotas): void;
+	clearQuotas(): void;
 }
 
 export interface IChatQuotas {
@@ -113,9 +114,12 @@ export class ChatQuotasService extends Disposable implements IChatQuotasService
 						id: MenuId.ChatCommandCenter,
 						group: 'a_first',
 						order: 1,
-						when: ContextKeyExpr.or(
-							ChatContextKeys.chatQuotaExceeded,
-							ChatContextKeys.completionsQuotaExceeded
+						when: ContextKeyExpr.and(
+							ChatContextKeys.Setup.installed,
+							ContextKeyExpr.or(
+								ChatContextKeys.chatQuotaExceeded,
+								ChatContextKeys.completionsQuotaExceeded
+							)
 						)
 					}
 				});
@@ -221,6 +225,12 @@ export class ChatQuotasService extends Disposable implements IChatQuotasService
 		this._onDidChangeQuotas.fire();
 	}
 
+	clearQuotas(): void {
+		if (this.quotas.chatQuotaExceeded || this.quotas.completionsQuotaExceeded) {
+			this.acceptQuotas({ chatQuotaExceeded: false, completionsQuotaExceeded: false, quotaResetDate: new Date(0) });
+		}
+	}
+
 	private updateContextKeys(): void {
 		this.chatQuotaExceededContextKey.set(this._quotas.chatQuotaExceeded);
 		this.completionsQuotaExceededContextKey.set(this._quotas.completionsQuotaExceeded);

src/vs/workbench/contrib/chat/browser/chatSetup.ts

@@ -56,6 +56,7 @@ import { CHAT_EDITING_SIDEBAR_PANEL_ID, CHAT_SIDEBAR_PANEL_ID } from './chatView
 import { ChatViewsWelcomeExtensions, IChatViewsWelcomeContributionRegistry } from './viewsWelcome/chatViewsWelcome.js';
 import { IChatQuotasService } from './chatQuotasService.js';
 import { Checkbox } from '../../../../base/browser/ui/toggle/toggle.js';
+import { mainWindow } from '../../../../base/browser/window.js';
 
 const defaultChat = {
 	extensionId: product.defaultChatAgent?.extensionId ?? '',
@@ -341,6 +342,15 @@ class ChatSetupRequests extends Disposable {
 				this.resolve();
 			}
 		}));
+
+		this._register(this.context.onDidChange(() => {
+			if (!this.context.state.installed || this.context.state.entitlement === ChatEntitlement.Unknown) {
+				// When the extension is not installed or the user is not entitled
+				// make sure to clear quotas so that any indicators are also gone
+				this.state = { entitlement: this.state.entitlement, quotas: undefined };
+				this.chatQuotasService.clearQuotas();
+			}
+		}));
 	}
 
 	private async resolve(): Promise<void> {
@@ -737,7 +747,8 @@ class ChatSetupController extends Disposable {
 
 		this.telemetryService.publicLog2<InstallChatEvent, InstallChatClassification>('commandCenter.chatInstall', { installResult, signedIn });
 
-		if (activeElement === getActiveElement()) {
+		const currentActiveElement = getActiveElement();
+		if (activeElement === currentActiveElement || currentActiveElement === mainWindow.document.body) {
 			(await showCopilotView(this.viewsService))?.focusInput();
 		}
 	}