Brings coverage back to 100%

Author: aridlehoover

app/controllers/initiatives_controller.rb

@@ -269,8 +269,6 @@ def update_params
   end
 
   def populate_dashboard_data(initiative)
-    return set_empty_dashboard_data unless initiative
-
     health_update_repo = Rails.application.config.x.health_update_repository
 
     dashboard = InitiativeDashboard.new(
@@ -377,51 +375,6 @@ def build_search_data
     end
   end
 
-  def set_empty_dashboard_data
-    @health_summary = { on_track: 0, at_risk: 0, off_track: 0 }
-    @total_active_projects = 0
-    @attention_required = []
-    @on_hold_projects = []
-    @never_updated_projects = []
-    @stale_projects_14 = []
-    @stale_projects_7 = []
-    @teams = []
-    @initiatives = []
-    @all_projects = []
-    @trend_data = []
-    @trend_direction = :stable
-    @trend_delta = 0.0
-    @weeks_of_data = 0
-    @confidence_score = 0
-    @confidence_level = :low
-    @confidence_factors = { biggest_drag: :insufficient_data, details: {} }
-
-    # Build empty presenters to avoid nil errors
-    @header_presenter = InitiativeHeaderPresenter.new(
-      entity: nil,
-      view_context: view_context
-    )
-    @health_presenter = HealthPresenter.new(
-      health: :not_available,
-      methodology: :initiative_rollup
-    )
-    @trend_presenter = TrendPresenter.new(
-      trend_data: [],
-      trend_direction: :stable,
-      trend_delta: 0.0,
-      weeks_of_data: 0
-    )
-    @confidence_presenter = ConfidencePresenter.new(
-      score: 0,
-      level: :low,
-      factors: {}
-    )
-    @edit_modal_presenter = InitiativeEditModalPresenter.new(
-      entity: nil,
-      view_context: view_context
-    )
-  end
-
   def team_repository
     Rails.application.config.x.team_repository
   end

app/controllers/projects_controller.rb

@@ -398,7 +398,7 @@ def build_project_presenters(project)
 
     @health_presenter = HealthPresenter.new(
       health: @project_health || project.health,
-      raw_score: @health_summary&.dig(:raw_score),
+      raw_score: @health_summary.dig(:raw_score),
       off_track_count: off_track_count,
       at_risk_count: at_risk_count,
       total_count: total_count,
@@ -473,8 +473,6 @@ def health_options
   end
 
   def selected_health_for(project)
-    return health_options.first unless project
-
     health_options.include?(project.health) ? project.health : health_options.first
   end
 end

app/controllers/teams_controller.rb

@@ -263,8 +263,6 @@ def update_params
   end
 
   def populate_team_dashboard_data(team)
-    return set_empty_team_dashboard_data unless team
-
     health_update_repo = Rails.application.config.x.health_update_repository
 
     dashboard = TeamDashboard.new(
@@ -371,50 +369,6 @@ def build_search_data
     end
   end
 
-  def set_empty_team_dashboard_data
-    @health_summary = { on_track: 0, at_risk: 0, off_track: 0 }
-    @total_active_projects = 0
-    @attention_required = []
-    @on_hold_projects = []
-    @never_updated_projects = []
-    @stale_projects_14 = []
-    @stale_projects_7 = []
-    @teams = []
-    @initiatives = []
-    @all_projects = []
-    @trend_data = []
-    @trend_direction = :stable
-    @trend_delta = 0.0
-    @weeks_of_data = 0
-    @confidence_score = 0
-    @confidence_level = :low
-
-    # Build empty presenters to avoid nil errors
-    @header_presenter = TeamHeaderPresenter.new(
-      entity: nil,
-      view_context: view_context
-    )
-    @health_presenter = HealthPresenter.new(
-      health: :not_available,
-      methodology: :team_rollup
-    )
-    @trend_presenter = TrendPresenter.new(
-      trend_data: [],
-      trend_direction: :stable,
-      trend_delta: 0.0,
-      weeks_of_data: 0
-    )
-    @confidence_presenter = ConfidencePresenter.new(
-      score: 0,
-      level: :low,
-      factors: {}
-    )
-    @edit_modal_presenter = TeamEditModalPresenter.new(
-      entity: nil,
-      view_context: view_context
-    )
-  end
-
   def team_repository
     Rails.application.config.x.team_repository
   end

spec/domain/teams/update_team_spec.rb

@@ -146,6 +146,16 @@
     expect(repository.find('team-123').archived?).to be(true)
   end
 
+  it 'allows explicitly setting archived status' do
+    repository = FakeTeamRepository.new
+    repository.update(id: 'team-123', team: build_team(name: 'Platform', archived: false))
+    action = described_class.new(team_repository: repository)
+
+    action.perform(id: 'team-123', archived: true)
+
+    expect(repository.find('team-123').archived?).to be(true)
+  end
+
   it 'allows setting description to empty string' do
     repository = FakeTeamRepository.new
     repository.update(id: 'team-123', team: build_team(name: 'Platform', description: 'Old desc'))

spec/helpers/application_helper_spec.rb

@@ -153,5 +153,25 @@
       expect(result).to include('breadcrumb__link--home')
       expect(result).to include('ParentProject')
     end
+
+    it 'shows initials for middle crumbs in deep hierarchy' do
+      great_grandparent_record = TeamRecord.create!(name: 'Engineering Division')
+      grandparent_record = TeamRecord.create!(name: 'Platform Team')
+      parent_record = TeamRecord.create!(name: 'Mobile Team')
+
+      great_grandparent = double('Team', name: 'Engineering Division', parent_team: nil, id: great_grandparent_record.id.to_s)
+      grandparent = double('Team', name: 'Platform Team', parent_team: great_grandparent, id: grandparent_record.id.to_s)
+      parent = double('Team', name: 'Mobile Team', parent_team: grandparent, id: parent_record.id.to_s)
+      child = double('Team', name: 'iOS Team', parent_team: parent)
+
+      result = helper.team_breadcrumb(child)
+
+      expect(result).to include('breadcrumb__link--home')
+      expect(result).to include('ED…')
+      expect(result).to include('title="Engineering Division"')
+      expect(result).to include('PT…')
+      expect(result).to include('title="Platform Team"')
+      expect(result).to include('Mobile Team')
+    end
   end
 end

spec/presenters/initiative_edit_modal_presenter_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+RSpec.describe InitiativeEditModalPresenter do
+  let(:view_context) { double('view_context', initiative_path: '/initiatives/1') }
+
+  describe 'with nil entity' do
+    subject(:presenter) { described_class.new(entity: nil, view_context: view_context) }
+
+    it 'returns empty string for name' do
+      expect(presenter.name).to eq('')
+    end
+
+    it 'returns empty string for description' do
+      expect(presenter.description).to eq('')
+    end
+
+    it 'returns empty string for point_of_contact' do
+      expect(presenter.point_of_contact).to eq('')
+    end
+
+    it 'returns false for archived?' do
+      expect(presenter.archived?).to be false
+    end
+
+    it 'returns nil for update_path' do
+      expect(presenter.update_path).to be_nil
+    end
+  end
+
+  describe 'with valid entity' do
+    let(:entity) do
+      double('Initiative',
+        name: 'Q1 Launch',
+        description: 'Launch new product',
+        point_of_contact: 'pm@example.com',
+        archived?: true,
+        id: '1'
+      )
+    end
+    subject(:presenter) { described_class.new(entity: entity, view_context: view_context) }
+
+    it 'returns entity name' do
+      expect(presenter.name).to eq('Q1 Launch')
+    end
+
+    it 'returns entity description' do
+      expect(presenter.description).to eq('Launch new product')
+    end
+
+    it 'returns entity point_of_contact' do
+      expect(presenter.point_of_contact).to eq('pm@example.com')
+    end
+
+    it 'returns entity archived?' do
+      expect(presenter.archived?).to be true
+    end
+  end
+end

spec/presenters/initiative_header_presenter_spec.rb

@@ -0,0 +1,79 @@
+require 'rails_helper'
+
+RSpec.describe InitiativeHeaderPresenter do
+  let(:view_context) { double('view_context', state_initiative_path: '/initiatives/1/state', initiative_breadcrumb: '<nav>breadcrumb</nav>') }
+
+  describe 'with nil entity' do
+    subject(:presenter) { described_class.new(entity: nil, view_context: view_context) }
+
+    it 'returns default name' do
+      expect(presenter.name).to eq('Initiative')
+    end
+
+    it 'returns nil description' do
+      expect(presenter.description).to be_nil
+    end
+
+    it 'returns nil point_of_contact' do
+      expect(presenter.point_of_contact).to be_nil
+    end
+
+    it 'returns false for archived?' do
+      expect(presenter.archived?).to be false
+    end
+
+    it 'returns nil current_state' do
+      expect(presenter.current_state).to be_nil
+    end
+
+    it 'returns nil state_path' do
+      expect(presenter.state_path).to be_nil
+    end
+
+    it 'returns empty breadcrumb' do
+      expect(presenter.breadcrumb).to eq([])
+    end
+  end
+
+  describe 'with valid entity' do
+    let(:entity) do
+      double('Initiative',
+        name: 'Q1 Launch',
+        description: 'Launch new product',
+        point_of_contact: 'pm@example.com',
+        archived?: false,
+        current_state: :in_progress,
+        id: '1'
+      )
+    end
+    subject(:presenter) { described_class.new(entity: entity, view_context: view_context) }
+
+    it 'returns entity name' do
+      expect(presenter.name).to eq('Q1 Launch')
+    end
+
+    it 'returns entity description' do
+      expect(presenter.description).to eq('Launch new product')
+    end
+
+    it 'returns entity point_of_contact' do
+      expect(presenter.point_of_contact).to eq('pm@example.com')
+    end
+
+    it 'returns entity archived?' do
+      expect(presenter.archived?).to be false
+    end
+
+    it 'returns entity current_state' do
+      expect(presenter.current_state).to eq(:in_progress)
+    end
+
+    it 'returns state_path' do
+      expect(presenter.state_path).to eq('/initiatives/1/state')
+    end
+
+    it 'returns breadcrumb' do
+      expect(presenter.breadcrumb).to eq('<nav>breadcrumb</nav>')
+    end
+  end
+end

spec/presenters/team_edit_modal_presenter_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+RSpec.describe TeamEditModalPresenter do
+  let(:view_context) { double('view_context', team_path: '/teams/1') }
+
+  describe 'with nil entity' do
+    subject(:presenter) { described_class.new(entity: nil, view_context: view_context) }
+
+    it 'returns empty string for name' do
+      expect(presenter.name).to eq('')
+    end
+
+    it 'returns empty string for description' do
+      expect(presenter.description).to eq('')
+    end
+
+    it 'returns empty string for point_of_contact' do
+      expect(presenter.point_of_contact).to eq('')
+    end
+
+    it 'returns false for archived?' do
+      expect(presenter.archived?).to be false
+    end
+
+    it 'returns nil for update_path' do
+      expect(presenter.update_path).to be_nil
+    end
+  end
+
+  describe 'with valid entity' do
+    let(:entity) do
+      double('Team',
+        name: 'Platform',
+        description: 'Platform team',
+        point_of_contact: 'platform@example.com',
+        archived?: true,
+        id: '1'
+      )
+    end
+    subject(:presenter) { described_class.new(entity: entity, view_context: view_context) }
+
+    it 'returns entity name' do
+      expect(presenter.name).to eq('Platform')
+    end
+
+    it 'returns entity description' do
+      expect(presenter.description).to eq('Platform team')
+    end
+
+    it 'returns entity point_of_contact' do
+      expect(presenter.point_of_contact).to eq('platform@example.com')
+    end
+
+    it 'returns entity archived?' do
+      expect(presenter.archived?).to be true
+    end
+  end
+end