Skip to content

Commit f48f421

Browse files
committed
Remove sample time checks.
We are iterating over the filtered samples, which were already constrained to the zoomed range. Checking the time again might be useful to handle error cases where samples not sorted by time and the range filtering didn't work properly, but I don't think that's useful either; _accumulateInBuffer will make sure to never write outside of its bounds.
1 parent 74655e0 commit f48f421

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/components/shared/thread/ActivityGraphFills.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -312,11 +312,7 @@ export class ActivityGraphFillComputer {
312312
beforeSampleCpuRatio: number,
313313
afterSampleCpuRatio: number
314314
) {
315-
const { rangeEnd, rangeStart } = this.renderedComponentSettings;
316-
if (sampleTime < rangeStart || sampleTime >= rangeEnd) {
317-
return;
318-
}
319-
315+
const { rangeStart } = this.renderedComponentSettings;
320316
const percentageBuffers = this.mutablePercentageBuffers[category];
321317
const percentageBuffer = this._pickPercentageBuffer(
322318
percentageBuffers,

0 commit comments

Comments
 (0)