Skip to content

Commit b79d3b0

Browse files
authored
Update home page message for the other browser case (#5866)
* Update home page message for the other browser case 1. Remove irrelevant comment. 2. Clarify that Firefox for desktop is needed for profiling which should eliminate confusion on, for example, Firefox for iOS. 3. Update download link, remove hardcoded en-US locale. * Update translation key
1 parent 147f2ca commit b79d3b0

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

locales/en-US/app.ftl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,8 @@ Home--record-instructions =
377377
keyboard shortcuts. The icon is blue when a profile is recording.
378378
Hit <kbd>Capture</kbd> to load the data into profiler.firefox.com.
379379
380-
Home--instructions-content =
381-
Recording performance profiles requires <a>{ -firefox-brand-name }</a>.
380+
Home--instructions-content2 =
381+
Recording performance profiles requires <a>{ -firefox-brand-name } for desktop</a>.
382382
However, existing profiles can be viewed in any modern browser.
383383
384384
Home--fenix-instructions-directly =

src/components/app/Home.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ type PopupInstallPhase =
230230
class HomeImpl extends React.PureComponent<HomeProps, HomeState> {
231231
constructor(props: HomeProps) {
232232
super(props);
233-
// Start by suggesting that we install the add-on.
234233
let popupInstallPhase = 'other-browser';
235234

236235
if (_isFirefox()) {
@@ -570,16 +569,15 @@ class HomeImpl extends React.PureComponent<HomeProps, HomeState> {
570569
<div>
571570
<DocsButton />
572571
<Localized
573-
id="Home--instructions-content"
572+
id="Home--instructions-content2"
574573
elems={{
575-
a: <a href="https://www.mozilla.org/en-US/firefox/new/" />,
574+
a: <a href="https://www.firefox.com" />,
576575
}}
577576
>
578577
<p>
579578
Recording performance profiles requires{' '}
580-
<a href="https://www.mozilla.org/en-US/firefox/new/">Firefox</a>
581-
. However, existing profiles can be viewed in any modern
582-
browser.
579+
<a>Firefox for desktop</a>. However, existing profiles can be
580+
viewed in any modern browser.
583581
</p>
584582
</Localized>
585583
<Localized

src/test/components/__snapshots__/Home.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -975,9 +975,9 @@ exports[`app/Home renders the information screen for other browsers 1`] = `
975975
<p>
976976
Recording performance profiles requires
977977
<a
978-
href="https://www.mozilla.org/en-US/firefox/new/"
978+
href="https://www.firefox.com"
979979
>
980-
⁨Firefox⁩
980+
⁨Firefox⁩ for desktop
981981
</a>
982982
.
983983
However, existing profiles can be viewed in any modern browser.

0 commit comments

Comments
 (0)