Commit 144efe4
authored
Fix JSZip dynamic import for esbuild (#5858)
Previously webpack was always using the CommonJS modules and had a
transform for ES modules.
JSZip is a CommonJS module, but it looks like now esbuild returns an ES
module namespace object for dynamic imports of CommonJS modules. Because
of that, the JSZip import contents live inside .default.
I checked other dynamic imports too and it looks like this is the only
one that is affected.
[Before](https://profiler.firefox.com/from-url/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2Faq0v3RbWRP62PNONPZ3kkQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_speedometer3.zip)
/
[After](https://deploy-preview-5858--perf-html.netlify.app/from-url/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2Faq0v3RbWRP62PNONPZ3kkQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_speedometer3.zip)1 parent 6a096f1 commit 144efe4
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1178 | 1178 | | |
1179 | 1179 | | |
1180 | 1180 | | |
1181 | | - | |
| 1181 | + | |
1182 | 1182 | | |
1183 | 1183 | | |
1184 | 1184 | | |
| |||
1369 | 1369 | | |
1370 | 1370 | | |
1371 | 1371 | | |
1372 | | - | |
| 1372 | + | |
1373 | 1373 | | |
1374 | 1374 | | |
1375 | 1375 | | |
| |||
0 commit comments