Skip to content

Commit 996f5d3

Browse files
committed
Verify readme and clean up tvos build
1 parent d1647da commit 996f5d3

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

analytics/integration_test/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ The manual test will involve running the integration test: `firebase_analytics_t
7878
- Choose a Non-Consumable in app purchase product.
7979
- Give it a Reference name of your choice (e.g. "ReferenceAppleIapProduct").
8080
- Give it a Product ID of your choice (e.g. "com.example.nonconsumable").
81-
- Make the app use the store kit file. In the top bar go to Product > Scheme > Edit Scheme... >
81+
- Make the app use the store kit file. In the top bar go to Product > Scheme > Edit Scheme...
8282
- In the left hand menu select Run
8383
- Select the Options tab on the right
8484
- Set the StoreKit Configuration dropdown to your new .storekit file.

scripts/gha/build_ios_tvos.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,6 @@ def build_universal_framework(frameworks_path, targets):
196196
platform_variant_architecture_dirs = os.listdir(framework_os_path)
197197
platform_variant_arch_map = defaultdict(list)
198198
for variant_architecture in platform_variant_architecture_dirs:
199-
if '-' not in variant_architecture:
200-
continue
201199
logging.debug('Inspecting ' + variant_architecture)
202200
platform_variant, architecture = variant_architecture.split('-')
203201
platform_variant_arch_map[platform_variant].append(architecture)
@@ -221,9 +219,9 @@ def build_universal_framework(frameworks_path, targets):
221219
return
222220

223221
# Pick any of the platform-arch directories as a reference candidate mainly
224-
# for obtaining a list of contained targets. Skip 'universal' if it's there.
225-
valid_dirs = [d for d in platform_variant_architecture_dirs if d != 'universal']
226-
reference_dir_path = os.path.join(framework_os_path, valid_dirs[0])
222+
# for obtaining a list of contained targets.
223+
reference_dir_path = os.path.join(framework_os_path,
224+
platform_variant_architecture_dirs[0])
227225
logging.debug('Using {0} as reference path for scanning '
228226
'targets'.format(reference_dir_path))
229227
# Filter only .framework directories and make sure the framework is
@@ -240,7 +238,9 @@ def build_universal_framework(frameworks_path, targets):
240238
# Eg: split firebase_auth.framework -> firebase_auth, .framework
241239
target, _ = os.path.splitext(target_framework)
242240
for variant_architecture_dir in platform_variant_architecture_dirs:
243-
if variant_architecture_dir == 'simulator-arm64' or variant_architecture_dir == 'universal':
241+
# Since we have arm64 for both device and simulator, lipo cannot combine
242+
# them in the same fat file. We ignore simulator-arm64.
243+
if variant_architecture_dir == 'simulator-arm64':
244244
continue
245245
# <build_dir>/<apple_os>/frameworks/<platform-arch>/
246246
# <target>.framework/target

0 commit comments

Comments
 (0)