Skip to content

Commit fd1bcb8

Browse files
committed
fix: config.py uses hardcoded outdated font URLs instead of fonts.py defaults
config.py get_fonts_config() was using hardcoded old defaults (Marianne with blocked URL, Roboto Mono with broken Google Fonts URL) that shadowed the fixed defaults in fonts.py. Now imports DEFAULT_FONT_SOURCES from fonts.py to ensure consistency. Fixes font installation still failing after v1.3.1. Bump to v1.3.2.
1 parent 5cb1966 commit fd1bcb8

File tree

4 files changed

+12
-16
lines changed

4 files changed

+12
-16
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [1.3.2] - 2025-12-08
11+
12+
### Fixed
13+
- **Config font defaults bug**: config.py was using hardcoded outdated font URLs instead of importing from fonts.py
14+
- This caused CI to still fail with "Invalid or corrupted zip file" even after v1.3.1 fix
15+
1016
## [1.3.1] - 2025-12-08
1117

1218
### Fixed
@@ -189,6 +195,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
189195
- `article-cli config show` - Show current configuration
190196
- `article-cli config create` - Create sample configuration
191197

198+
[1.3.2]: https://github.com/feelpp/article.cli/releases/tag/v1.3.2
192199
[1.3.1]: https://github.com/feelpp/article.cli/releases/tag/v1.3.1
193200
[1.3.0]: https://github.com/feelpp/article.cli/releases/tag/v1.3.0
194201
[1.2.0]: https://github.com/feelpp/article.cli/releases/tag/v1.2.0

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
44

55
[project]
66
name = "article-cli"
7-
version = "1.3.1"
7+
version = "1.3.2"
88
authors = [
99
{name = "Christophe Prud'homme", email = "prudhomm@cemosis.fr"},
1010
]

src/article_cli/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
- Git hooks setup
99
"""
1010

11-
__version__ = "1.3.1"
11+
__version__ = "1.3.2"
1212
__author__ = "Christophe Prud'homme"
1313
__email__ = "prudhomm@cemosis.fr"
1414

src/article_cli/config.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -214,23 +214,12 @@ def get_poster_config(self) -> Dict[str, Any]:
214214

215215
def get_fonts_config(self) -> Dict[str, Any]:
216216
"""Get font installation configuration"""
217-
# Default font sources
218-
default_sources = [
219-
{
220-
"name": "Marianne",
221-
"url": "https://www.systeme-de-design.gouv.fr/uploads/Marianne_fd0ba9c190.zip",
222-
"description": "French government official font",
223-
},
224-
{
225-
"name": "Roboto Mono",
226-
"url": "https://fonts.google.com/download?family=Roboto+Mono",
227-
"description": "Google's monospace font",
228-
},
229-
]
217+
# Import default sources from fonts module to keep them in sync
218+
from .fonts import DEFAULT_FONT_SOURCES
230219

231220
return {
232221
"directory": self.get("fonts", "directory", "fonts"),
233-
"sources": self.get("fonts", "sources", default_sources),
222+
"sources": self.get("fonts", "sources", DEFAULT_FONT_SOURCES),
234223
}
235224

236225
def get_themes_config(self) -> Dict[str, Any]:

0 commit comments

Comments
 (0)