ODFVs with write_to_online_store=True crash offline stores (they get queried from offline store, but shouldn't)

[astronautas]

Expected Behavior

On-demand feature views (ODFVs) with write_to_online_store=True should be materialized to the online store, but they should never be queried from the offline store (ODFVs, no data for them in the offline store).

Current Behavior

ODFVs with write_to_online_store=True are being queried from offline stores. In the code here
, if an ODFV has the write_to_online_store flag set, it is treated as a regular feature view. As a result, it gets queried from the offline store.

However, ODFVs are not historical feature views and do not have any data in offline stores, so they should never be queried there.

Steps to reproduce

Run get_historical_features for an ODFV with write_to_online_store=True.

Specifications

• Version: 0.57.0
• Clickhouse offline store.

Possible Solution

Not sure yet, but basically remove the condition? Is it even needed here? Seems incorrect...

[astronautas]

@franciscojavierarceo You added this condition, could you elaborate why it's needed? It's crashing our offline store after upgrade, but we really need write_to_online_store=True for inference efficiency :D.

[franciscojavierarceo]

It shouldn't be, let me try and take it out. Unless you can quickly, I'm working on something else for the pytorch announcement. If you can cut a quick PR we can get it in the next release (which I'm hoping to do today or tomorrow).

CC @ntkathole

[astronautas]

@franciscojavierarceo I can do it myself, no worries ;). Just wanted to see why it was done that way and if it makes sense to remove it.

[franciscojavierarceo]

Fixed, thanks @astronautas

[astronautas]

no worries!