Metro 0.83.5 no longer exports types from 0.83.3

[tido64]

I don't know if this was intentional but our builds started to fail with 0.83.5:

  src/metro.ts:2:15 - error TS2614: Module '"metro"' has no exported member 'Module'. Did you mean to use 'import Module from "metro"' instead?
  
  2 import type { Module, ReadOnlyGraph, SerializerOptions } from "metro";
                  ~~~~~~
  
  src/metro.ts:2:23 - error TS2614: Module '"metro"' has no exported member 'ReadOnlyGraph'. Did you mean to use 'import ReadOnlyGraph from "metro"' instead?
  
  2 import type { Module, ReadOnlyGraph, SerializerOptions } from "metro";
                          ~~~~~~~~~~~~~
  
  src/metro.ts:2:38 - error TS2614: Module '"metro"' has no exported member 'SerializerOptions'. Did you mean to use 'import SerializerOptions from "metro"' instead?
  
  2 import type { Module, ReadOnlyGraph, SerializerOptions } from "metro";
                                         ~~~~~~~~~~~~~~~~~

And indeed, the types are now gone:

0.83.3	0.83.5

[tido64]

cc @robhogan

[robhogan]

Hi @tido64 - the old hand-written types have now been replaced by fully auto-generated types (which at least means they're accurate and comprehensive now!) but yeah we might have lost specific type exports if they were never exported from Flow and only existed in manual TS.

If the types are implicitly public anyway (those three all are via config.serializer.customSerializer) I'm happy to add type exports from Flow and regenerate TS. I'm running an audit now to see if we can find them all.

Edit - FYI:

Major changes found in index.d.ts:

Star exports REMOVED (present in 0.83.3, removed in auto-generation):

1. export * from './Asset';
2. export * from './DeltaBundler/types';
3. export * from './ModuleGraph/worker/collectDependencies';
4. export * from './Server';
5. export * from './lib/reporting';

Explicit re-exports removed:

• export {HttpServer, HttpsServer}; (from node http/https)

Types still explicitly exported in new version:

• export type {AssetData} from './Assets';
• export type {Reporter, ReportableEvent} from './lib/reporting';
• export type {TerminalReportableEvent} from './lib/TerminalReporter';
• export type {MetroConfig};
• export {Terminal, JsonReporter, TerminalReporter};
• export {loadConfig, mergeConfig, resolveConfig};

Interface removed:

• WebsocketServer (custom interface, replaced by WS Server import)

Enumerated exports from each star-exported file (old version at commit 926c8ef5957e):

From ./Asset (Asset.d.ts):

• AssetDataWithoutFiles (interface)
• AssetData (interface) — STILL exported in new version via export type {AssetData} from './Assets'

From ./DeltaBundler/types (DeltaBundler/types.d.ts) — 20 exports:

• MixedOutput (interface)
• AsyncDependencyType (type)
• TransformResultDependency (interface)
• Dependency (interface)
• Module (interface, generic)
• Dependencies (type, generic)
• ReadOnlyDependencies (type, generic)
• TransformInputOptions (type)
• GraphInputOptions (type)
• ReadOnlyGraph (interface, generic)
• Graph (re-export from ./Graph)
• TransformResult (interface, generic)
• TransformResultWithSource (interface, generic)
• TransformFn (type, generic)
• AllowOptionalDependenciesWithOptions (interface)
• AllowOptionalDependencies (type)
• BundlerResolution (interface)
• Options (interface, generic)
• DeltaResult (interface, generic)
• SerializerOptions (interface, generic)

From ./ModuleGraph/worker/collectDependencies (collectDependencies.d.ts) — 4 exports:

• ContextMode (type)
• ContextFilter (interface)
• RequireContextParams (interface)
• DynamicRequiresBehavior (type)

From ./Server (Server.d.ts) — 9 exports:

• SegmentLoadData (interface)
• BundleMetadata (interface)
• ProcessStartContext (interface)
• ProcessDeleteContext (interface)
• ProcessEndContext (interface, generic)
• ServerOptions (type)
• DefaultGraphOptions (interface)
• DefaultBundleOptions (interface)
• Server (default class export)

From ./lib/reporting (lib/reporting.d.ts) — 3 exports:

• BundleDetails (interface)
• ReportableEvent (type) — STILL exported via export type {ReportableEvent} from './lib/reporting'
• Reporter (interface) — STILL exported via export type {Reporter} from './lib/reporting'

Named re-exports removed from index.d.ts:

• HttpServer (from 'http') — was export {HttpServer, HttpsServer}
• HttpsServer (from 'https') — was export {HttpServer, HttpsServer}

Interfaces removed from index.d.ts itself:

• WebsocketServer (custom interface with handleUpgrade method)
• RunMetroOptions — replaced with a different type definition (Omit-based)
• RunServerOptions — still exported but changed from interface to Readonly type
• RunServerResult — still exported but changed from interface to plain type
• RunBuildOptions — still exported but changed from interface to plain type
• RunBuildResult — still exported but changed from interface to plain type
• AttachMetroCLIOptions — changed from interface to type, no longer exported

New exports in 0.83.5 not in 0.83.3:

• JsonReporter (value export)
• TerminalReportableEvent (type re-export from './lib/TerminalReporter')
• DependenciesCommandOptions (used internally, not exported)
• onClose option added to RunServerOptions