Merge pull request #90 from natsirtguy/fix/golangci-lint

fix: resolve all golangci-lint issues

Author: f

cmd/mcptools/commands/call.go

@@ -11,6 +11,46 @@ import (
 	"github.com/spf13/cobra"
 )
 
+// parseCallArgs parses command line arguments for the call command.
+// Returns entityName, parsedArgs for the command to execute.
+func parseCallArgs(cmdArgs []string) (string, []string) {
+	parsedArgs := []string{}
+	entityName := ""
+	i := 0
+	entityExtracted := false
+
+	for i < len(cmdArgs) {
+		switch {
+		case (cmdArgs[i] == FlagFormat || cmdArgs[i] == FlagFormatShort) && i+1 < len(cmdArgs):
+			FormatOption = cmdArgs[i+1]
+			i += 2
+		case (cmdArgs[i] == FlagParams || cmdArgs[i] == FlagParamsShort) && i+1 < len(cmdArgs):
+			ParamsString = cmdArgs[i+1]
+			i += 2
+		case (cmdArgs[i] == FlagTransport) && i+1 < len(cmdArgs):
+			TransportOption = cmdArgs[i+1]
+			i += 2
+		case (cmdArgs[i] == FlagAuthUser) && i+1 < len(cmdArgs):
+			AuthUser = cmdArgs[i+1]
+			i += 2
+		case (cmdArgs[i] == FlagAuthHeader) && i+1 < len(cmdArgs):
+			AuthHeader = cmdArgs[i+1]
+			i += 2
+		case !entityExtracted:
+			entityName = cmdArgs[i]
+			entityExtracted = true
+			i++
+		case cmdArgs[i] == FlagServerLogs:
+			ShowServerLogs = true
+			i++
+		default:
+			parsedArgs = append(parsedArgs, cmdArgs[i])
+			i++
+		}
+	}
+	return entityName, parsedArgs
+}
+
 // CallCmd creates the call command.
 func CallCmd() *cobra.Command {
 	return &cobra.Command{
@@ -33,42 +73,7 @@ func CallCmd() *cobra.Command {
 				os.Exit(1)
 			}
 
-			cmdArgs := args
-			parsedArgs := []string{}
-			entityName := ""
-
-			i := 0
-			entityExtracted := false
-
-			for i < len(cmdArgs) {
-				switch {
-				case (cmdArgs[i] == FlagFormat || cmdArgs[i] == FlagFormatShort) && i+1 < len(cmdArgs):
-					FormatOption = cmdArgs[i+1]
-					i += 2
-				case (cmdArgs[i] == FlagParams || cmdArgs[i] == FlagParamsShort) && i+1 < len(cmdArgs):
-					ParamsString = cmdArgs[i+1]
-					i += 2
-				case (cmdArgs[i] == FlagTransport) && i+1 < len(cmdArgs):
-					TransportOption = cmdArgs[i+1]
-					i += 2
-				case (cmdArgs[i] == FlagAuthUser) && i+1 < len(cmdArgs):
-					AuthUser = cmdArgs[i+1]
-					i += 2
-				case (cmdArgs[i] == FlagAuthHeader) && i+1 < len(cmdArgs):
-					AuthHeader = cmdArgs[i+1]
-					i += 2
-				case !entityExtracted:
-					entityName = cmdArgs[i]
-					entityExtracted = true
-					i++
-				case cmdArgs[i] == FlagServerLogs:
-					ShowServerLogs = true
-					i++
-				default:
-					parsedArgs = append(parsedArgs, cmdArgs[i])
-					i++
-				}
-			}
+			entityName, parsedArgs := parseCallArgs(args)
 
 			if entityName == "" {
 				fmt.Fprintln(os.Stderr, "Error: entity name is required")

cmd/mcptools/commands/new.go

@@ -11,12 +11,7 @@ import (
 )
 
 // Constants for template options.
-const (
-	sdkTypeScript  = "ts"
-	transportStdio = "stdio"
-	transportSSE   = "sse"
-	transportHTTP  = "http"
-)
+const sdkTypeScript = "ts"
 
 // NewCmd returns a new 'new' command for scaffolding MCP projects.
 func NewCmd() *cobra.Command {
@@ -49,13 +44,13 @@ Examples:
 			}
 
 			// Validate transport flag
-			if transportFlag != "" && transportFlag != transportStdio && transportFlag != transportSSE && transportFlag != transportHTTP {
+			if transportFlag != "" && transportFlag != TransportStdio && transportFlag != TransportSSE && transportFlag != TransportHTTP {
 				return fmt.Errorf("unsupported transport: %s (supported options: stdio, sse, http)", transportFlag)
 			}
 
 			// Set default transport if not specified
 			if transportFlag == "" {
-				transportFlag = transportStdio
+				transportFlag = TransportStdio
 			}
 
 			// Parse components from args
@@ -127,11 +122,12 @@ func createProjectStructure(components map[string]string, sdk, transport string)
 
 	// Create index.ts with the server setup
 	var serverTemplateFile string
-	if transport == transportSSE {
+	switch transport {
+	case TransportSSE:
 		serverTemplateFile = filepath.Join(templatesDir, "server_sse.ts")
-	} else if transport == transportHTTP {
+	case TransportHTTP:
 		serverTemplateFile = filepath.Join(templatesDir, "server_http.ts")
-	} else {
+	default:
 		// Use stdio by default
 		serverTemplateFile = filepath.Join(templatesDir, "server_stdio.ts")
 	}

cmd/mcptools/commands/root.go

@@ -9,16 +9,16 @@ import (
 
 // flags.
 const (
-	FlagFormat         = "--format"
-	FlagFormatShort    = "-f"
-	FlagParams         = "--params"
-	FlagParamsShort    = "-p"
-	FlagHelp           = "--help"
-	FlagHelpShort      = "-h"
-	FlagServerLogs     = "--server-logs"
-	FlagTransport      = "--transport"
-	FlagAuthUser       = "--auth-user"
-	FlagAuthHeader     = "--auth-header"
+	FlagFormat      = "--format"
+	FlagFormatShort = "-f"
+	FlagParams      = "--params"
+	FlagParamsShort = "-p"
+	FlagHelp        = "--help"
+	FlagHelpShort   = "-h"
+	FlagServerLogs  = "--server-logs"
+	FlagTransport   = "--transport"
+	FlagAuthUser    = "--auth-user"
+	FlagAuthHeader  = "--auth-header"
 )
 
 // entity types.
@@ -28,6 +28,13 @@ const (
 	EntityTypeRes    = "resource"
 )
 
+// transport types.
+const (
+	TransportSSE   = "sse"
+	TransportHTTP  = "http"
+	TransportStdio = "stdio"
+)
+
 var (
 	// FormatOption is the format option for the command, valid values are "table", "json", and
 	// "pretty".

cmd/mcptools/commands/test_helpers.go

@@ -55,6 +55,7 @@ func (m *MockTransport) Close() error {
 }
 
 // GetSessionId returns an empty session ID for the mock transport.
+// nolint:revive // Method name required by transport.Interface from mcp-go
 func (m *MockTransport) GetSessionId() string {
 	return ""
 }

cmd/mcptools/commands/utils.go

@@ -33,56 +33,55 @@ func IsHTTP(str string) bool {
 // It returns the header value and a cleaned URL (with embedded credentials removed).
 func buildAuthHeader(originalURL string) (string, string, error) {
 	cleanURL := originalURL
-	
+
 	// First, check if we have explicit auth-user flag with username:password format
 	if AuthUser != "" {
 		// Parse username:password format
 		if !strings.Contains(AuthUser, ":") {
 			return "", originalURL, fmt.Errorf("auth-user must be in username:password format (missing colon)")
 		}
-		
+
 		parts := strings.SplitN(AuthUser, ":", 2)
 		username := parts[0]
 		password := parts[1]
-		
+
 		// Allow empty username or password, but not both
-		if username == "" && password == "" {
-			// Both empty, treat as no auth
-		} else {
+		if username != "" || password != "" {
 			// Create basic auth header
 			auth := base64.StdEncoding.EncodeToString([]byte(username + ":" + password))
 			header := "Basic " + auth
 			return header, cleanURL, nil
 		}
+		// Both empty, treat as no auth - fall through
 	}
-	
+
 	// Check for custom auth header
 	if AuthHeader != "" {
 		return AuthHeader, cleanURL, nil
 	}
-	
+
 	// Extract credentials from URL if embedded
 	parsedURL, err := url.Parse(originalURL)
 	if err != nil {
 		return "", originalURL, err
 	}
-	
+
 	if parsedURL.User != nil {
 		username := parsedURL.User.Username()
 		password, _ := parsedURL.User.Password()
-		
+
 		if username != "" {
 			// Create basic auth header
 			auth := base64.StdEncoding.EncodeToString([]byte(username + ":" + password))
-			
+
 			// Clean the URL by removing user info
 			parsedURL.User = nil
 			cleanURL = parsedURL.String()
-			
+
 			return "Basic " + auth, cleanURL, nil
 		}
 	}
-	
+
 	return "", cleanURL, nil
 }
 
@@ -106,7 +105,7 @@ var CreateClientFunc = func(args []string, _ ...client.ClientOption) (*client.Cl
 
 	if len(args) == 1 && IsHTTP(args[0]) {
 		// Validate transport option for HTTP URLs
-		if TransportOption != "http" && TransportOption != "sse" {
+		if TransportOption != TransportHTTP && TransportOption != TransportSSE {
 			return nil, fmt.Errorf("invalid transport option: %s (supported: http, sse)", TransportOption)
 		}
 
@@ -128,7 +127,7 @@ var CreateClientFunc = func(args []string, _ ...client.ClientOption) (*client.Cl
 		// Many MCP servers require clients to accept both JSON responses and event streams
 		headers["Accept"] = "application/json, text/event-stream"
 
-		if TransportOption == "sse" {
+		if TransportOption == TransportSSE {
 			// For SSE transport, use transport.ClientOption
 			c, err = client.NewSSEMCPClient(cleanURL, transport.WithHeaders(headers))
 		} else {

cmd/mcptools/commands/web.go

@@ -1269,20 +1269,20 @@ func handleCall(cache *MCPClientCache) http.HandlerFunc {
 		defer cache.mutex.Unlock()
 
 		switch requestData.Type {
-		case "tool":
+		case EntityTypeTool:
 			var toolResponse *mcp.CallToolResult
 			request := mcp.CallToolRequest{}
 			request.Params.Name = requestData.Name
 			request.Params.Arguments = requestData.Params
 			toolResponse, callErr = cache.client.CallTool(context.Background(), request)
 			resp = ConvertJSONToMap(toolResponse)
-		case "resource":
+		case EntityTypeRes:
 			var resourceResponse *mcp.ReadResourceResult
 			request := mcp.ReadResourceRequest{}
 			request.Params.URI = requestData.Name
 			resourceResponse, callErr = cache.client.ReadResource(context.Background(), request)
 			resp = ConvertJSONToMap(resourceResponse)
-		case "prompt":
+		case EntityTypePrompt:
 			var promptResponse *mcp.GetPromptResult
 			request := mcp.GetPromptRequest{}
 			request.Params.Name = requestData.Name

cmd/mcptools/transport_test.go

@@ -57,4 +57,4 @@ func TestIsHTTP(t *testing.T) {
 			t.Errorf("IsHTTP(%s) = %v, expected %v", tc.url, result, tc.expected)
 		}
 	}
-}
+}