-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
Description
To upgrade from PTB 1.6.0 to 5.1.1 and avoid large file changes which would hinder other work, we introduced in #360 overrides in the noxfile.py for the nox session format:check and format:fix. These & their related code imports should be removed so that the transformers-extensions stays on top of the formatting features of the PTB.
Note that if it's desired to uncouple the many changes, it would be recommended to do the following:
- Update the
noxfile.pyso that_pyupgradeuses--py10-plusand executeformat:fix-> this will update the types - If additional changes have been added to the PTB
format:fix(as determined by comparing thenoxfile.pyhere to the PTB source code, then one could next introduceruffinto the_code_formatoption and executeformat:fix-> this would removed unused imports
-- please refer to the plethora of online information on how to prevent removing specific unused imports, but we have basic information at:
https://exasol.github.io/python-toolbox/main/user_guide/features/formatting_code/troubleshooting.html#the-automatic-formatting-is-doing-x-but-we-shouldn-t-do-that-because-of-y - Then, remove the overrides & execute
format:fixagain
Reactions are currently unavailable