-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
refactoringCode improvement without behavior changeCode improvement without behavior change
Description
Background
Currently, as workaround, we have a DummyOsExecutor (in task TestRunnerDBTestTask) which is a fallback when the environment info is incomplete, which can happen if ITDE's SpawnTestEnvironment was launched for an external database. See exasol/integration-test-docker-environment#403
After the linked issue is fixed, we can remove the DummyOsExecutor and adapt the test DockerRunDBTestExternalDBTest, which then will need to manage the SSH file.
Acceptance Criteria
- Use latest version of ITDE with fix for SpawnTestEnvironment for external database cannot be used with SSH executor integration-test-docker-environment#403
- Remove the
DummyOsExecutorin (in task TestRunnerDBTestTask) - Simplify TestRunnerDBTestTask._executor_factory()
- Adapt the test DockerRunDBTestExternalDBTest
- Use
f"--db-os-access {DbOsAccess.SSH.name}"forrun-db-testcommand - Manage the SSH Key file of the (external) docker db and add to
run-db-testcommand the user and key-file
- Use
Metadata
Metadata
Assignees
Labels
refactoringCode improvement without behavior changeCode improvement without behavior change